From 648e0564cc6bf26d17323db52848485654d64bcf Mon Sep 17 00:00:00 2001 From: Greggman Date: Wed, 16 Oct 2024 15:16:11 +0900 Subject: [PATCH] Texture Builtins: offset to case from subcase (#4004) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Missed 2 😱 --- .../execution/expression/call/builtin/textureGather.spec.ts | 2 +- .../execution/expression/call/builtin/textureSample.spec.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/webgpu/shader/execution/expression/call/builtin/textureGather.spec.ts b/src/webgpu/shader/execution/expression/call/builtin/textureGather.spec.ts index 4a8632977c7d..c066e807a9ba 100644 --- a/src/webgpu/shader/execution/expression/call/builtin/textureGather.spec.ts +++ b/src/webgpu/shader/execution/expression/call/builtin/textureGather.spec.ts @@ -294,13 +294,13 @@ Parameters: .combine('format', kTestableColorFormats) .filter(t => isFillable(t.format)) .combine('minFilter', ['nearest', 'linear'] as const) + .combine('offset', [false, true] as const) .beginSubcases() .combine('samplePoints', kSamplePointMethods) .combine('C', ['i32', 'u32'] as const) .combine('A', ['i32', 'u32'] as const) .combine('addressModeU', ['clamp-to-edge', 'repeat', 'mirror-repeat'] as const) .combine('addressModeV', ['clamp-to-edge', 'repeat', 'mirror-repeat'] as const) - .combine('offset', [false, true] as const) ) .beforeAllSubcases(t => { t.skipIfTextureFormatNotSupported(t.params.format); diff --git a/src/webgpu/shader/execution/expression/call/builtin/textureSample.spec.ts b/src/webgpu/shader/execution/expression/call/builtin/textureSample.spec.ts index 2741c4860a33..2f2041a40e8f 100644 --- a/src/webgpu/shader/execution/expression/call/builtin/textureSample.spec.ts +++ b/src/webgpu/shader/execution/expression/call/builtin/textureSample.spec.ts @@ -732,8 +732,8 @@ Parameters: .filter(t => isDepthTextureFormat(t.format)) // MAINTENANCE_TODO: Remove when support for depth24plus, depth24plus-stencil8, and depth32float-stencil8 is added. .filter(t => isEncodableTextureFormat(t.format)) - .beginSubcases() .combine('offset', [false, true] as const) + .beginSubcases() .combine('samplePoints', kSamplePointMethods) .combine('addressMode', ['clamp-to-edge', 'repeat', 'mirror-repeat'] as const) .combine('minFilter', ['nearest', 'linear'] as const)