Skip to content

Commit

Permalink
Fix wrong _errorLine in operation/shader_module/compilation_info.spec…
Browse files Browse the repository at this point in the history
….ts (#2088)

This patch fixes the wrong value of _errorLine of the shader named
'carriage-return' in kInvalidShaderSources. The correct error line
should be 5:
line 1: \n
line 2: @vertex fn main() -> @Builtin(position) vec4<f32> {\r\n
line 3: \n
line 4: // Expected Error: unknown function 'unknown'
line 5: return unknown(0.0, 0.0, 0.0, 1.0);
  • Loading branch information
Jiawei-Shao authored Dec 16, 2022
1 parent 47d19f5 commit 5daf3ca
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const kInvalidShaderSources = [
{
valid: false,
name: 'carriage-return',
_errorLine: 4,
_errorLine: 5,
_code:
`
@vertex fn main() -> @builtin(position) vec4<f32> {` +
Expand Down

0 comments on commit 5daf3ca

Please sign in to comment.