From 3c73a4b6b088466e8d5b5fe2ea3ee3eff63b51f5 Mon Sep 17 00:00:00 2001
From: Greggman <github@greggman.com>
Date: Wed, 18 Dec 2024 17:45:30 -0800
Subject: [PATCH] Compat: Skip texture sync tests that use storage textures if
 0 (#4104)

---
 .../texture/same_subresource.spec.ts          | 55 ++++++++++++++++++-
 1 file changed, 53 insertions(+), 2 deletions(-)

diff --git a/src/webgpu/api/operation/memory_sync/texture/same_subresource.spec.ts b/src/webgpu/api/operation/memory_sync/texture/same_subresource.spec.ts
index 2286d585d19d..eef4f81680ea 100644
--- a/src/webgpu/api/operation/memory_sync/texture/same_subresource.spec.ts
+++ b/src/webgpu/api/operation/memory_sync/texture/same_subresource.spec.ts
@@ -9,7 +9,7 @@ Memory Synchronization Tests for Texture: read before write, read after write, a
 import { makeTestGroup } from '../../../../../common/framework/test_group.js';
 import { assert, memcpy, unreachable } from '../../../../../common/util/util.js';
 import { EncodableTextureFormat } from '../../../../format_info.js';
-import { GPUTest } from '../../../../gpu_test.js';
+import { GPUTest, MaxLimitsTestMixin } from '../../../../gpu_test.js';
 import { align } from '../../../../util/math.js';
 import { getTextureCopyLayout } from '../../../../util/texture/layout.js';
 import {
@@ -31,7 +31,7 @@ import {
   kOpInfo,
 } from './texture_sync_test.js';
 
-export const g = makeTestGroup(GPUTest);
+export const g = makeTestGroup(MaxLimitsTestMixin(GPUTest));
 
 const fullscreenQuadWGSL = `
   struct VertexOutput {
@@ -53,6 +53,18 @@ const fullscreenQuadWGSL = `
   }
 `;
 
+function readOpNeedsStorageTexture({ op, in: context }: { op: Op; in: OperationContext }) {
+  return (
+    op === 'sample' && (context === 'render-pass-encoder' || context === 'render-bundle-encoder')
+  );
+}
+
+function writeOpNeedsStorageTexture({ op, in: context }: { op: Op; in: OperationContext }) {
+  return (
+    op === 'storage' && (context === 'render-pass-encoder' || context === 'render-bundle-encoder')
+  );
+}
+
 class TextureSyncTestHelper extends OperationContextHelper {
   private texture: GPUTexture;
 
@@ -73,6 +85,29 @@ class TextureSyncTestHelper extends OperationContextHelper {
     });
   }
 
+  static skipIfNeedStorageTexturesAndNoStorageTextures(
+    t: GPUTest,
+    reads: { op: Op; in: OperationContext }[],
+    writes: { op: Op; in: OperationContext }[]
+  ) {
+    if (!t.isCompatibility) {
+      return;
+    }
+
+    if (t.device.limits.maxStorageTexturesInFragmentStage! >= 1) {
+      return;
+    }
+
+    const needStorageTexture =
+      reads.reduce((need, read) => need || readOpNeedsStorageTexture(read), false) ||
+      writes.reduce((need, write) => need || writeOpNeedsStorageTexture(write), false);
+
+    t.skipIf(
+      needStorageTexture,
+      `maxStorageTexturesInFragmentStage(${t.device.limits.maxStorageTexturesInFragmentStage}) < 1`
+    );
+  }
+
   /**
    * Perform a read operation on the test texture.
    * @return GPUTexture copy containing the contents.
@@ -558,6 +593,11 @@ g.test('rw')
       })
   )
   .fn(t => {
+    TextureSyncTestHelper.skipIfNeedStorageTexturesAndNoStorageTextures(
+      t,
+      [t.params.read],
+      [t.params.write]
+    );
     const helper = new TextureSyncTestHelper(t, {
       usage:
         GPUTextureUsage.COPY_DST |
@@ -610,6 +650,11 @@ g.test('wr')
       })
   )
   .fn(t => {
+    TextureSyncTestHelper.skipIfNeedStorageTexturesAndNoStorageTextures(
+      t,
+      [t.params.read],
+      [t.params.write]
+    );
     const helper = new TextureSyncTestHelper(t, {
       usage: kOpInfo[t.params.read.op].readUsage | kOpInfo[t.params.write.op].writeUsage,
     });
@@ -654,6 +699,12 @@ g.test('ww')
       })
   )
   .fn(t => {
+    TextureSyncTestHelper.skipIfNeedStorageTexturesAndNoStorageTextures(
+      t,
+      [],
+      [t.params.first, t.params.second]
+    );
+
     const helper = new TextureSyncTestHelper(t, {
       usage:
         GPUTextureUsage.COPY_SRC |