From 16e822a3bb90bb1711881a7703538b9b76076e35 Mon Sep 17 00:00:00 2001 From: David Neto Date: Thu, 25 Jul 2024 14:10:37 -0400 Subject: [PATCH] phony assignment is not valid at module scope (#3876) --- src/webgpu/listing_meta.json | 1 + src/webgpu/shader/validation/statement/phony.spec.ts | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/src/webgpu/listing_meta.json b/src/webgpu/listing_meta.json index 272b97a69d29..89760b89db0b 100644 --- a/src/webgpu/listing_meta.json +++ b/src/webgpu/listing_meta.json @@ -2695,6 +2695,7 @@ "webgpu:shader,validation,statement,increment_decrement:var_init_type:*": { "subcaseMS": 270.034 }, "webgpu:shader,validation,statement,loop:break_if_type:*": { "subcaseMS": 5.488 }, "webgpu:shader,validation,statement,loop:parse:*": { "subcaseMS": 16.168 }, + "webgpu:shader,validation,statement,phony:module_scope:*": { "subcaseMS": 0.381 }, "webgpu:shader,validation,statement,phony:parse:*": { "subcaseMS": 149.639 }, "webgpu:shader,validation,statement,phony:rhs_constructible:*": { "subcaseMS": 244.513 }, "webgpu:shader,validation,statement,phony:rhs_with_decl:*": { "subcaseMS": 15.874 }, diff --git a/src/webgpu/shader/validation/statement/phony.spec.ts b/src/webgpu/shader/validation/statement/phony.spec.ts index dfd8edc4c639..95a471e85ec6 100644 --- a/src/webgpu/shader/validation/statement/phony.spec.ts +++ b/src/webgpu/shader/validation/statement/phony.spec.ts @@ -170,3 +170,10 @@ fn f() { }`; t.expectCompileResult(kTests[t.params.test].pass, code); }); + +g.test('module_scope') + .desc(`Phony assignment is not valid at module scope`) + .fn(t => { + const code = `_ = 1; `; + t.expectCompileResult(false, code); + });