fix: distinguish between nil and non-nil allowed tools (#977)

thedadams · web-flow · commit c810be4bf185 · 2025-05-30T10:52:44.000-04:00
If allowedTools is nil, then all tools are allowed. If allowed tools is
non-nil and has length zero, then no tools are allowed.

Signed-off-by: Donnie Adams &lt;donnie@acorn.io&gt;
diff --git a/pkg/mcp/loader.go b/pkg/mcp/loader.go
@@ -181,7 +181,7 @@ func (l *Local) Close() error {
 }
 
 func (l *Local) sessionToTools(ctx context.Context, session *Session, toolName string, allowedTools []string) ([]types.Tool, error) {
-	allToolsAllowed := len(allowedTools) == 0 || slices.Contains(allowedTools, "*")
+	allToolsAllowed := allowedTools == nil || slices.Contains(allowedTools, "*")
 
 	tools, err := session.Client.ListTools(ctx, mcp.ListToolsRequest{})
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ func (l *Local) Close() error {`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`func (l Local) sessionToTools(ctx context.Context, session Session, toolName string, allowedTools []string) ([]types.Tool, error) {`
`184`		`- allToolsAllowed := len(allowedTools) == 0 \|\| slices.Contains(allowedTools, "*")`
	`184`	`+ allToolsAllowed := allowedTools == nil \|\| slices.Contains(allowedTools, "*")`
`185`	`185`
`186`	`186`	`tools, err := session.Client.ListTools(ctx, mcp.ListToolsRequest{})`
`187`	`187`	`if err != nil {`