Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Detached bottom sheet modal animates incorrectly #2047

Open
doughsay opened this issue Nov 19, 2024 · 4 comments
Open

[Bug]: Detached bottom sheet modal animates incorrectly #2047

doughsay opened this issue Nov 19, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@doughsay
Copy link

doughsay commented Nov 19, 2024

Version

v5

Reanimated Version

v3

Gesture Handler Version

v2

Platforms

Android

What happened?

When a detached bottom sheet modal is presented, the bottom edge animates incorrectly. See the attached video:

bottom-sheet-detached-animation.webm

The height of the sheet appears to be too high at first, and then shrinks after opening. I took the example almost exactly from this page: https://gorhom.dev/react-native-bottom-sheet/detach-modal
which shows the animation as I'd like it, without the sheet height animating:

bottom-sheet-detach-preview.mp4

Reproduction steps

See my reproduction repo here: https://github.com/doughsay/bottom-sheet-example

This is not reproducible in a snack, because it appears Expo 52 is not available there yet. The example repo above does reproduce it.

Reproduction sample

https://github.com/doughsay/bottom-sheet-example

Relevant log output

No response

@doughsay doughsay added the bug Something isn't working label Nov 19, 2024
@doughsay
Copy link
Author

doughsay commented Nov 19, 2024

I tried reproducing in a snack, and it works as expected: https://snack.expo.dev/bfCKrXN2AHnfkRqXDbBRD. This only happens when using a non-expo-go development build, same exact code.

@epolat-github
Copy link

What is the situation for this issue? @doughsay could you solve it? I'm seeing the same animation problem when the bottom sheet is set to detached.

@doughsay
Copy link
Author

doughsay commented Dec 6, 2024

I have no solution, no. I am using react-native-screens / react-navigation formSheets, which were just introduced in v7. I've abandoned trying to use this library for now... (to clarify though: react-navigation doesn't do detached sheets)

@epolat-github
Copy link

Ah okay, bummer. Yeah formSheets with detents are beautiful imo. Hopefully this issue will be answered/solved somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants