Reverse conditional checker (#729)

googlesamples · Jan 31, 2025 · 1867fe4 · 1867fe4
1 parent ced86f2
commit 1867fe4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+# Upcoming
+* Android Resolver - Reverse conditional checker for `packaging` keyword in maintemplate based on android gradle plugin version. Fixes #715
+
 # Version 1.2.184 - Jan 28, 2025
 * Android Resolver - Update and resolve `packaging` keyword in maintemplate
   based on android gradle plugin version.

diff --git a/source/AndroidResolver/src/PlayServicesResolver.cs b/source/AndroidResolver/src/PlayServicesResolver.cs
@@ -2354,7 +2354,7 @@ internal static IList<string> PackagingOptionsLines(ICollection<Dependency> depe
                     lines.Add("android {");
 
                     // `packagingOptions` is replaced by `packaging` keyword in Android Gradle plugin 8.0+
-                    if ((new Dependency.VersionComparer()).Compare("8.0", AndroidGradlePluginVersion) <= 0) {
+                    if ((new Dependency.VersionComparer()).Compare("8.0", AndroidGradlePluginVersion) >= 0) {
                         lines.Add("  packaging {");
                     } else {
                         lines.Add("  packagingOptions {");