Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't vendor protoc on Windows #814

Open
XAMPPRocky opened this issue Oct 10, 2023 · 2 comments
Open

Don't vendor protoc on Windows #814

XAMPPRocky opened this issue Oct 10, 2023 · 2 comments
Labels
kind/bug Something isn't working

Comments

@XAMPPRocky
Copy link
Collaborator

protobuf-src depends on auto tools which requires sh, so this means if you're trying to compile on Windows, it will fail.

error: failed to run custom build command for `protobuf-src v1.1.0+21.5`

Caused by:
  process didn't exit successfully: `C:\Users\erin.power\quilkin\target\release\build\protobuf-src-668a2e07a68a77fb\build-script-build` (exit code: 101)
  --- stderr
  thread 'main' panicked at '
  `sh` is required to run `configure`

  build script failed, must exit now', C:\Users\erin.power\.cargo\registry\src\index.crates.io-6f17d22bba15001f\autotools-0.2.6\src\lib.rs:781:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
@XAMPPRocky XAMPPRocky added the kind/bug Something isn't working label Oct 10, 2023
@markmandel
Copy link
Contributor

MaterializeInc/rust-protobuf-native#4 is relevant, with links off to how some other projects solved the issue.

@benesch
Copy link

benesch commented May 13, 2024

The latest version of protobuf-src now builds with CMake rather than autotools. I've not yet tested this, but it may "just work" with Windows now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants