fix(gh-1071): Fix file location in github output

Use the lint.FileLocationFromPBLocation method to get the correct
problem locations for the GitHub Actions formatter, rather than
re-implementing the conversion from PB location to file location.

Author: James Socol

cmd/api-linter/github_actions.go

@@ -33,22 +33,8 @@ func formatGitHubActionOutput(responses []lint.Response) []byte {
 
 			fmt.Fprintf(&buf, "::error file=%s", response.FilePath)
 			if problem.Location != nil {
-				// Some findings are *line level* and only have start positions but no
-				// starting column. Construct a switch fallthrough to emit as many of
-				// the location indicators are included.
-				switch len(problem.Location.Span) {
-				case 4:
-					fmt.Fprintf(&buf, ",endColumn=%d", problem.Location.Span[3])
-					fallthrough
-				case 3:
-					fmt.Fprintf(&buf, ",endLine=%d", problem.Location.Span[2])
-					fallthrough
-				case 2:
-					fmt.Fprintf(&buf, ",col=%d", problem.Location.Span[1])
-					fallthrough
-				case 1:
-					fmt.Fprintf(&buf, ",line=%d", problem.Location.Span[0])
-				}
+				location := lint.FileLocationFromPBLocation(problem.Location)
+				fmt.Fprintf(&buf, ",line=%d,col=%d,endLine=%d,endColumn=%d", location.Start.Line, location.Start.Column, location.End.Line, location.End.Column)
 			}
 
 			// GitHub uses :: as control characters (which are also used to delimit

cmd/api-linter/github_actions_test.go

@@ -53,27 +53,11 @@ func TestFormatGitHubActionOutput(t *testing.T) {
 								Span: []int32{5, 6, 7},
 							},
 						},
-						{
-							RuleID:  "line::col",
-							Message: "Line and column",
-							Location: &descriptorpb.SourceCodeInfo_Location{
-								Span: []int32{5, 6},
-							},
-						},
-						{
-							RuleID:  "line",
-							Message: "Line only",
-							Location: &descriptorpb.SourceCodeInfo_Location{
-								Span: []int32{5},
-							},
-						},
 					},
 				},
 			},
-			want: `::error file=example.proto,endColumn=8,endLine=7,col=6,line=5,title=line։։col։։endLine։։endColumn::line, column, endline, and endColumn
-::error file=example.proto,endLine=7,col=6,line=5,title=line։։col։։endLine::Line, column, and endline
-::error file=example.proto,col=6,line=5,title=line։։col::Line and column
-::error file=example.proto,line=5,title=line::Line only
+			want: `::error file=example.proto,line=6,col=7,endLine=8,endColumn=8,title=line։։col։։endLine։։endColumn::line, column, endline, and endColumn
+::error file=example.proto,line=6,col=7,endLine=6,endColumn=7,title=line։։col։։endLine::Line, column, and endline
 `,
 		},
 		{
@@ -98,8 +82,8 @@ func TestFormatGitHubActionOutput(t *testing.T) {
 					},
 				},
 			},
-			want: `::error file=example.proto,endColumn=4,endLine=3,col=2,line=1,title=core։։naming_formats։։field_names::\n\nhttps://linter.aip.dev/naming_formats/field_names
-::error file=example.proto,endColumn=8,endLine=7,col=6,line=5,title=core։։naming_formats։։field_names::multi\nline\ncomment\n\nhttps://linter.aip.dev/naming_formats/field_names
+			want: `::error file=example.proto,line=2,col=3,endLine=4,endColumn=4,title=core։։naming_formats։։field_names::\n\nhttps://linter.aip.dev/naming_formats/field_names
+::error file=example.proto,line=6,col=7,endLine=8,endColumn=8,title=core։։naming_formats։։field_names::multi\nline\ncomment\n\nhttps://linter.aip.dev/naming_formats/field_names
 `,
 		},
 		{