remove # pylint: ...

Author: Borda

fire/__main__.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# pylint: disable=invalid-name
+
 """Enables use of Python Fire as a "main" function (i.e. "python -m fire").
 
 This allows using Fire with third-party libraries without modifying their code.
@@ -63,7 +63,7 @@ def import_from_file_path(path):
   if spec is None:
     raise OSError('Unable to load module from specified path.')
 
-  module = util.module_from_spec(spec)  # pylint: disable=no-member
+  module = util.module_from_spec(spec)
   spec.loader.exec_module(module)
 
   return module, module_name

fire/completion_test.py

@@ -29,7 +29,7 @@ def testCompletionBashScript(self):
         ['halt'],
         ['halt', '--now'],
     ]
-    script = completion._BashScript(name='command', commands=commands)  # pylint: disable=protected-access
+    script = completion._BashScript(name='command', commands=commands)
     self.assertIn('command', script)
     self.assertIn('halt', script)
 
@@ -44,7 +44,7 @@ def testCompletionFishScript(self):
         ['halt'],
         ['halt', '--now'],
     ]
-    script = completion._FishScript(name='command', commands=commands)  # pylint: disable=protected-access
+    script = completion._FishScript(name='command', commands=commands)
     self.assertIn('command', script)
     self.assertIn('halt', script)
     self.assertIn('-l now', script)

fire/console/console_attr.py

@@ -649,15 +649,15 @@ def GetConsoleAttr(encoding=None, reset=False):
   Returns:
     The global ConsoleAttr state object.
   """
-  attr = ConsoleAttr._CONSOLE_ATTR_STATE  # pylint: disable=protected-access
+  attr = ConsoleAttr._CONSOLE_ATTR_STATE
   if not reset:
     if not attr:
       reset = True
     elif encoding and encoding != attr.GetEncoding():
       reset = True
   if reset:
     attr = ConsoleAttr(encoding=encoding)
-    ConsoleAttr._CONSOLE_ATTR_STATE = attr  # pylint: disable=protected-access
+    ConsoleAttr._CONSOLE_ATTR_STATE = attr
   return attr
 
 

fire/console/console_attr_os.py

@@ -54,11 +54,11 @@ def GetTermSize():
 
 def _GetTermSizePosix():
   """Returns the Posix terminal x and y dimensions."""
-  # pylint: disable=g-import-not-at-top
+
   import fcntl
-  # pylint: disable=g-import-not-at-top
+
   import struct
-  # pylint: disable=g-import-not-at-top
+
   import termios
 
   def _GetXY(fd):
@@ -96,7 +96,7 @@ def _GetTermSizeWindows():
   """Returns the Windows terminal x and y dimensions."""
   # pylint:disable=g-import-not-at-top
   import struct
-  # pylint: disable=g-import-not-at-top
+
   from ctypes import create_string_buffer
   # pylint:disable=g-import-not-at-top
   from ctypes import windll
@@ -124,7 +124,7 @@ def _GetTermSizeEnvironment():
 
 def _GetTermSizeTput():
   """Returns the terminal x and y dimensions from tput(1)."""
-  import subprocess  # pylint: disable=g-import-not-at-top
+  import subprocess
   output = encoding.Decode(subprocess.check_output(['tput', 'cols'],
                                                    stderr=subprocess.STDOUT))
   cols = int(output)
@@ -160,9 +160,9 @@ def GetRawKeyFunction():
 
 def _GetRawKeyFunctionPosix():
   """_GetRawKeyFunction helper using Posix APIs."""
-  # pylint: disable=g-import-not-at-top
+
   import tty
-  # pylint: disable=g-import-not-at-top
+
   import termios
 
   def _GetRawKeyPosix():
@@ -223,7 +223,7 @@ def _GetKeyChar():
 
 def _GetRawKeyFunctionWindows():
   """_GetRawKeyFunction helper using Windows APIs."""
-  # pylint: disable=g-import-not-at-top
+
   import msvcrt
 
   def _GetRawKeyWindows():

fire/console/platforms.py

@@ -30,7 +30,7 @@ class Error(Exception):
   pass
 
 
-class InvalidEnumValue(Error):  # pylint: disable=g-bad-exception-name
+class InvalidEnumValue(Error):
   """Exception for when a string could not be parsed to a valid enum value."""
 
   def __init__(self, given, enum_type, options):
@@ -53,7 +53,7 @@ class OperatingSystem(object):
   class _OS(object):
     """A single operating system."""
 
-    # pylint: disable=redefined-builtin
+
     def __init__(self, id, name, file_name):
       self.id = id
       self.name = name
@@ -169,7 +169,7 @@ class Architecture(object):
   class _ARCH(object):
     """A single architecture."""
 
-    # pylint: disable=redefined-builtin
+
     def __init__(self, id, name, file_name):
       self.id = id
       self.name = name

fire/core.py

@@ -182,7 +182,7 @@ class FireError(Exception):
   """
 
 
-class FireExit(SystemExit):  # pylint: disable=g-bad-exception-name
+class FireExit(SystemExit):
   """An exception raised by Fire to the client in the case of a FireError.
 
   The trace of the Fire program is available on the `trace` property.

fire/core_test.py

@@ -25,14 +25,14 @@
 class CoreTest(testutils.BaseTestCase):
 
   def testOneLineResult(self):
-    self.assertEqual(core._OneLineResult(1), '1')  # pylint: disable=protected-access
-    self.assertEqual(core._OneLineResult('hello'), 'hello')  # pylint: disable=protected-access
-    self.assertEqual(core._OneLineResult({}), '{}')  # pylint: disable=protected-access
-    self.assertEqual(core._OneLineResult({'x': 'y'}), '{"x": "y"}')  # pylint: disable=protected-access
+    self.assertEqual(core._OneLineResult(1), '1')
+    self.assertEqual(core._OneLineResult('hello'), 'hello')
+    self.assertEqual(core._OneLineResult({}), '{}')
+    self.assertEqual(core._OneLineResult({'x': 'y'}), '{"x": "y"}')
 
   def testOneLineResultCircularRef(self):
     circular_reference = tc.CircularReference()
-    self.assertEqual(core._OneLineResult(circular_reference.create()),  # pylint: disable=protected-access
+    self.assertEqual(core._OneLineResult(circular_reference.create()),
                      "{'y': {...}}")
 
   @mock.patch('fire.interact.Embed')

fire/decorators_test.py

@@ -82,7 +82,7 @@ def example6(self, **kwargs):
 class WithVarArgs:
 
   @decorators.SetParseFn(str)
-  def example7(self, arg1, arg2=None, *varargs, **kwargs):  # pylint: disable=keyword-arg-before-vararg
+  def example7(self, arg1, arg2=None, *varargs, **kwargs):
     return arg1, arg2, varargs, kwargs
 
 

fire/docstrings_test.py

@@ -17,11 +17,11 @@
 from fire import docstrings
 from fire import testutils
 
-# pylint: disable=invalid-name
+
 DocstringInfo = docstrings.DocstringInfo
 ArgInfo = docstrings.ArgInfo
 KwargInfo = docstrings.KwargInfo
-# pylint: enable=invalid-name
+
 
 
 class DocstringsTest(testutils.BaseTestCase):
@@ -45,12 +45,12 @@ def test_one_line_simple_whitespace(self):
     self.assertEqual(expected_docstring_info, docstring_info)
 
   def test_one_line_too_long(self):
-    # pylint: disable=line-too-long
+
     docstring = """A one line docstring that is both a little too verbose
     and a little too long so it keeps going well beyond a reasonable length
     for a one-liner.
     """
-    # pylint: enable=line-too-long
+
     docstring_info = docstrings.parse(docstring)
     expected_docstring_info = DocstringInfo(
         summary='A one line docstring that is both a little too verbose and '
@@ -60,11 +60,11 @@ def test_one_line_too_long(self):
     self.assertEqual(expected_docstring_info, docstring_info)
 
   def test_one_line_runs_over(self):
-    # pylint: disable=line-too-long
+
     docstring = """A one line docstring that is both a little too verbose
     and a little too long so it runs onto a second line.
     """
-    # pylint: enable=line-too-long
+
     docstring_info = docstrings.parse(docstring)
     expected_docstring_info = DocstringInfo(
         summary='A one line docstring that is both a little too verbose and '
@@ -306,7 +306,7 @@ def test_strip_blank_lines(self):
     lines = ['   ', '  foo  ', '   ']
     expected_output = ['  foo  ']
 
-    self.assertEqual(expected_output, docstrings._strip_blank_lines(lines))  # pylint: disable=protected-access
+    self.assertEqual(expected_output, docstrings._strip_blank_lines(lines))
 
   def test_numpy_colon_in_description(self):
     docstring = """

fire/helptext.py

@@ -463,7 +463,7 @@ def _CreateFlagItem(flag, docstring_info, spec, required=False,
   Returns:
     A string to be used in constructing the help screen for the function.
   """
-  # pylint: disable=g-bad-todo
+
   # TODO(MichaelCG8): Get type and default information from docstrings if it is
   # not available in FullArgSpec. This will require updating
   # fire.docstrings.parser().