Skip to content

Commit adff65e

Browse files
authored
Disable incompatible benchmarks for cloud experiments (#2030)
Temporarily disable benchmark `stb_stbi_read_fuzzer` and `openh264_decoder_fuzzer`from cloud experiments, becaue they are [proven](#2023 (comment)) to be incompatible in cloud build/run environment. @addisoncrump kindly confirmed that they [work in local experiments](#2023 (comment)).
1 parent e72f5bb commit adff65e

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

experiment/run_experiment.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,18 @@ def get_git_hash(allow_uncommitted_changes):
298298
return ''
299299

300300

301+
def _filter_incompatible_benchmarks(config: dict,
302+
benchmarks: List[str]) -> List[str]:
303+
"""Removes benchmarks that are incompatible with build/run environment."""
304+
if config['local_experiment']:
305+
return benchmarks
306+
if 'openh264_decoder_fuzzer' in benchmarks:
307+
benchmarks.remove('openh264_decoder_fuzzer')
308+
if 'stb_stbi_read_fuzzer' in benchmarks:
309+
benchmarks.remove('stb_stbi_read_fuzzer')
310+
return benchmarks
311+
312+
301313
def start_experiment( # pylint: disable=too-many-arguments
302314
experiment_name: str,
303315
config_filename: str,
@@ -322,7 +334,7 @@ def start_experiment( # pylint: disable=too-many-arguments
322334

323335
config = read_and_validate_experiment_config(config_filename)
324336
config['fuzzers'] = fuzzers
325-
config['benchmarks'] = benchmarks
337+
config['benchmarks'] = _filter_incompatible_benchmarks(config, benchmarks)
326338
config['experiment'] = experiment_name
327339
config['git_hash'] = get_git_hash(allow_uncommitted_changes)
328340
config['no_seeds'] = no_seeds

service/experiment-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
# Unless you are a fuzzbench maintainer running this service, this
33
# will not work with your setup.
44

5-
trials: 20
6-
max_total_time: 82800 # 23 hours, the default time for preemptible experiments.
5+
trials: 2
6+
max_total_time: 2100
77
cloud_project: fuzzbench
88
docker_registry: gcr.io/fuzzbench
99
cloud_compute_zone: us-central1-c
@@ -15,7 +15,7 @@ preemptible_runners: true
1515

1616
# This experiment should generate a report that is combined with other public
1717
# "production" experiments.
18-
merge_with_nonprivate: true
18+
merge_with_nonprivate: false
1919

2020
# This experiment should be merged with other reports in later experiments.
2121
private: false

service/gcbrun_experiment.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import logging
2121
import os
2222
import sys
23+
# dummy
2324

2425
# pytype: disable=import-error
2526
import github # pylint: disable=import-error

0 commit comments

Comments
 (0)