Improve error message for when nnx.Modules use jax or numpy arrays as leaf values #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
reviewed
Jan 20, 2025
| @@ -446,7 +446,8 @@ def _graph_flatten( | |||
| if isinstance(value, (jax.Array, np.ndarray)): | |||
| path_str = '/'.join(map(str, (*path, key))) | |||
| raise ValueError( | |||
| f'Arrays leaves are not supported, at {path_str!r}: {value}' | |||
| f'The variable at the path {path_str!r} with value = {value} is of type:' \ | |||
| f'{type(value)}. Leaf values of this type are not supported for nnx.Modules.' | |||
There was a problem hiding this comment.
Suggested change
| f'{type(value)}. Leaf values of this type are not supported for nnx.Modules.' | |
| f'{type(value)}. Leaf values of this type are not supported for nnx.Modules or nnx.Object in general.' |
cgarciae
approved these changes
Jan 20, 2025
|
@RaghuSpaceRajan updated |
…does nothing (it used to control a checkpointing behavior that has since been optimized away). PiperOrigin-RevId: 718571228
PiperOrigin-RevId: 718899289
|
@cgarciae Done. |
|
Actually, for some reason, it shows me as author for some of the rebased commits. Not sure if that's normal, it's the first time I have rebased across forks. Let me know if should just redo the thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4480
Checklist
checks if that's the case).