Fix: Actually call ValidateOptions (#8665)

thejtshow · web-flow · commit 5218e29aa4bc · 2025-08-12T15:30:35.000-07:00
* fix: actually call ValidateOptions

* convert error to warning in validateoptions
diff --git a/src/flatc.cpp b/src/flatc.cpp
@@ -758,6 +758,8 @@ FlatCOptions FlatCompiler::ParseFromCommandLineArguments(int argc,
     }
   }
 
+  ValidateOptions(options);
+
   return options;
 }
 
@@ -766,9 +768,8 @@ void FlatCompiler::ValidateOptions(const FlatCOptions &options) {
 
   if (!options.filenames.size()) Error("missing input files", false, true);
 
-  if (opts.proto_mode) {
-    if (options.any_generator)
-      Error("cannot generate code directly from .proto files", true);
+  if (opts.proto_mode && options.any_generator) {
+    Warn("cannot generate code directly from .proto files", true);
   } else if (!options.any_generator && options.conform_to_schema.empty() &&
              options.annotate_schema.empty()) {
     Error("no options: specify at least one generator.", true);

Original file line number	Diff line number	Diff line change
`@@ -758,6 +758,8 @@ FlatCOptions FlatCompiler::ParseFromCommandLineArguments(int argc,`
`758`	`758`	`}`
`759`	`759`	`}`
`760`	`760`
	`761`	`+ ValidateOptions(options);`
	`762`	`+`
`761`	`763`	`return options;`
`762`	`764`	`}`
`763`	`765`
`@@ -766,9 +768,8 @@ void FlatCompiler::ValidateOptions(const FlatCOptions &options) {`
`766`	`768`
`767`	`769`	`if (!options.filenames.size()) Error("missing input files", false, true);`
`768`	`770`
`769`		`- if (opts.proto_mode) {`
`770`		`- if (options.any_generator)`
`771`		`- Error("cannot generate code directly from .proto files", true);`
	`771`	`+ if (opts.proto_mode && options.any_generator) {`
	`772`	`+ Warn("cannot generate code directly from .proto files", true);`
`772`	`773`	`} else if (!options.any_generator && options.conform_to_schema.empty() &&`
`773`	`774`	`options.annotate_schema.empty()) {`
`774`	`775`	`Error("no options: specify at least one generator.", true);`