Hidden fields shouldn't have in-row spacing

[alexcui03]

Check for duplicates

• I have searched for similar issues before opening a new one.

Description

Example:
The above block has a hidden field '+', and that field in the below block is visible.

The above block has an extra in-row spacing after the hidden field. According to RenderInfo.getInRowSpacing_ and RenderInfo.addElemSpacing_, the renderer will always create a spacer whether the field is visible or not. The expected behavior should be that there's only one spacing between two visible fields.

A possible solution is to add/remove fields instead of setting the visibility of fields. Since hidden fields also have some other rendering bugs (like #3223), maybe the visibility of fields should be deprecated?

Reproduction steps

1. Create a block with a hidden field.

Stack trace

Screenshots

No response

Browsers

No response

[maribethb]

Hi @alexcui03, thanks for filing this issue. We do not generally support the idea of "hidden" fields in uncollapsed blocks, as noted in the other issue you linked. The correct implementation would be to add and remove the field as part of a mutator instead. Please post in our forum if you need additional assistance implementing this.

The setVisible method you are probably using is marked @internal in the code and it doesn't appear in our reference documentation. Anything marked @internal is generally not part of our public API and may be removed or changed without warning, so it's in your best interest to avoid using it.

Thanks, and let us know if you have additional questions.