You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched for similar issues before opening a new one.
Component
blockly-samples infrastructure
Description
We recently changed how we structure the dependencies in samples to use hoisting so we eliminate the "two blockly problem"
However running npm run test:ghpages:beta will try to install blockly@beta inside every plugin which is now wrong. That's fine for examples where we're not using hoisting. For samples it needs to install blockly@beta at the root of samples. but there might be problems if the plugins say they require a version of blockly that isn't compatible with the beta.
Don't run this command until this is fixed
Reproduction steps
Stack trace
No response
Screenshots
No response
The text was updated successfully, but these errors were encountered:
Just delete this command, and if you want to do what it did do a manual npm install of the beta before running npm run test:ghpages.
Modify the implementation to install the beta at the root and accept that sometimes things will break if the versions are incompatible.
Have this command attempt to ensure that each of the plugins/examples at least claims to be compatible, so that we can test (but maybe some of them will be broken if they're not really compatible.
Per discussion with @rachel-fenichel: recommend going with option 2, since most typically when running this command we're going to be interested in discovering actual incompatibilities between plugins and Blockly beta, rather than discovering (or carefully avoiding) nominal peerDependency version incompatiblities.
Check for duplicates
Component
blockly-samples infrastructure
Description
We recently changed how we structure the dependencies in samples to use hoisting so we eliminate the "two blockly problem"
However running
npm run test:ghpages:beta
will try to install blockly@beta inside every plugin which is now wrong. That's fine for examples where we're not using hoisting. For samples it needs to install blockly@beta at the root of samples. but there might be problems if the plugins say they require a version of blockly that isn't compatible with the beta.Don't run this command until this is fixed
Reproduction steps
Stack trace
No response
Screenshots
No response
The text was updated successfully, but these errors were encountered: