Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run test:ghpages:beta doesn't work for hoisting #2397

Open
1 task done
maribethb opened this issue Jun 28, 2024 · 2 comments
Open
1 task done

npm run test:ghpages:beta doesn't work for hoisting #2397

maribethb opened this issue Jun 28, 2024 · 2 comments
Labels
type: bug Something isn't working
Milestone

Comments

@maribethb
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

blockly-samples infrastructure

Description

We recently changed how we structure the dependencies in samples to use hoisting so we eliminate the "two blockly problem"

However running npm run test:ghpages:beta will try to install blockly@beta inside every plugin which is now wrong. That's fine for examples where we're not using hoisting. For samples it needs to install blockly@beta at the root of samples. but there might be problems if the plugins say they require a version of blockly that isn't compatible with the beta.

Don't run this command until this is fixed

Reproduction steps

Stack trace

No response

Screenshots

No response

@maribethb maribethb added type: bug Something isn't working triage labels Jun 28, 2024
@cpcallen
Copy link
Contributor

cpcallen commented Jul 3, 2024

There seem to be three ways we could go here:

  1. Just delete this command, and if you want to do what it did do a manual npm install of the beta before running npm run test:ghpages.
  2. Modify the implementation to install the beta at the root and accept that sometimes things will break if the versions are incompatible.
  3. Have this command attempt to ensure that each of the plugins/examples at least claims to be compatible, so that we can test (but maybe some of them will be broken if they're not really compatible.

It's not clear what the best approach is.

@cpcallen cpcallen added this to the Upcoming milestone Jul 22, 2024
@cpcallen cpcallen removed the triage label Jul 22, 2024
@cpcallen
Copy link
Contributor

Per discussion with @rachel-fenichel: recommend going with option 2, since most typically when running this command we're going to be interested in discovering actual incompatibilities between plugins and Blockly beta, rather than discovering (or carefully avoiding) nominal peerDependency version incompatiblities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants