From 27a2305ab1acdb0e9292741275a879bb23c00fbb Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Fri, 21 Aug 2026 16:08:10 -0700 Subject: [PATCH 01/13] fix test --- .../Implementations/Fake/GIDAppCheckProviderFake.h | 2 +- .../Implementations/Fake/GIDAppCheckProviderFake.m | 2 +- .../Sources/GIDAppCheck/Implementations/GIDAppCheck.m | 6 +----- GoogleSignIn/Sources/GIDSignIn.m | 2 +- GoogleSignIn/Tests/Unit/GIDAppCheckTest.m | 2 +- GoogleSignIn/Tests/Unit/GIDSignInTest.m | 7 +++++-- Package.swift | 7 ++++--- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.h b/GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.h index e294273f..5a862c16 100644 --- a/GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.h +++ b/GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.h @@ -16,7 +16,7 @@ #import #if TARGET_OS_IOS && !TARGET_OS_MACCATALYST -#import +@import AppCheckCore; @class GACAppCheckToken; diff --git a/GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.m b/GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.m index 903fc3ff..44e54692 100644 --- a/GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.m +++ b/GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.m @@ -16,7 +16,7 @@ #if TARGET_OS_IOS && !TARGET_OS_MACCATALYST -#import +@import AppCheckCore; NSUInteger const kGIDAppCheckProviderFakeError = 1; diff --git a/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m b/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m index a886eec4..302f2aa8 100644 --- a/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m +++ b/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m @@ -18,11 +18,7 @@ #if TARGET_OS_IOS && !TARGET_OS_MACCATALYST -#import -#import -#import -#import -#import +@import AppCheckCore; #import "GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h" #import "GoogleSignIn/Sources/Public/GoogleSignIn/GIDAppCheckError.h" diff --git a/GoogleSignIn/Sources/GIDSignIn.m b/GoogleSignIn/Sources/GIDSignIn.m index abbb803e..f3ca57da 100644 --- a/GoogleSignIn/Sources/GIDSignIn.m +++ b/GoogleSignIn/Sources/GIDSignIn.m @@ -30,7 +30,7 @@ #import "GoogleSignIn/Sources/GIDSignInCallbackSchemes.h" #import "GoogleSignIn/Sources/GIDClaimsInternalOptions.h" #if TARGET_OS_IOS && !TARGET_OS_MACCATALYST -#import +@import AppCheckCore; #import "GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h" #import "GoogleSignIn/Sources/GIDAppCheck/UI/GIDActivityIndicatorViewController.h" #import "GoogleSignIn/Sources/GIDEMMErrorHandler.h" diff --git a/GoogleSignIn/Tests/Unit/GIDAppCheckTest.m b/GoogleSignIn/Tests/Unit/GIDAppCheckTest.m index 7c0610ae..61e0624e 100644 --- a/GoogleSignIn/Tests/Unit/GIDAppCheckTest.m +++ b/GoogleSignIn/Tests/Unit/GIDAppCheckTest.m @@ -17,7 +17,7 @@ #if TARGET_OS_IOS && !TARGET_OS_MACCATALYST #import -#import +@import AppCheckCore; #import "GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h" #import "GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.h" #import "GoogleSignIn/Sources/Public/GoogleSignIn/GIDAppCheckError.h" diff --git a/GoogleSignIn/Tests/Unit/GIDSignInTest.m b/GoogleSignIn/Tests/Unit/GIDSignInTest.m index ed959f12..658311a2 100644 --- a/GoogleSignIn/Tests/Unit/GIDSignInTest.m +++ b/GoogleSignIn/Tests/Unit/GIDSignInTest.m @@ -35,7 +35,7 @@ #import "GoogleSignIn/Sources/GIDClaimsInternalOptions.h" #if TARGET_OS_IOS && !TARGET_OS_MACCATALYST -#import +@import AppCheckCore; #import "GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h" #import "GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.h" #import "GoogleSignIn/Sources/GIDEMMErrorHandler.h" @@ -426,8 +426,11 @@ - (void)testConfigureFailsNoTokenOrError { XCTestExpectation *configureFailsExpecation = [self expectationWithDescription:@"Configure fails expectation"]; + NSError *expectedError = [NSError errorWithDomain:kGIDAppCheckErrorDomain + code:kGIDAppCheckUnexpectedError + userInfo:nil]; GIDAppCheckProviderFake *fakeProvider = - [[GIDAppCheckProviderFake alloc] initWithAppCheckToken:nil error:nil]; + [[GIDAppCheckProviderFake alloc] initWithAppCheckToken:nil error:expectedError]; GIDAppCheck *appCheck = [[GIDAppCheck alloc] initWithAppCheckProvider:fakeProvider userDefaults:_testUserDefaults]; diff --git a/Package.swift b/Package.swift index bad348a0..119f7842 100644 --- a/Package.swift +++ b/Package.swift @@ -44,9 +44,10 @@ let package = Package( .package( url: "https://github.com/openid/AppAuth-iOS.git", from: "3.0.0"), - .package( - url: "https://github.com/google/app-check.git", - from: "11.0.0"), +// .package( +// url: "https://github.com/google/app-check.git", +// from: "11.0.0"), + .package(url: "https://github.com/google/app-check.git", branch: "pb-swift"), .package( url: "https://github.com/google/GTMAppAuth.git", from: "6.0.0"), From aedfc764c4410d0fc6ba4c2c981c006b667d9cbd Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Fri, 21 Aug 2026 16:22:09 -0700 Subject: [PATCH 02/13] Fix isPrepared logic in GIDAppCheck to check error instead of token --- .../Sources/GIDAppCheck/Implementations/GIDAppCheck.m | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m b/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m index 302f2aa8..8fb78dbe 100644 --- a/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m +++ b/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m @@ -119,7 +119,7 @@ - (void)prepareForAppCheckWithCompletion:(nullable GIDAppCheckPrepareCompletion) userInfo:nil]; } - if (result.token) { + if (!result.error) { [self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey]; } @@ -139,9 +139,9 @@ - (void)prepareForAppCheckWithCompletion:(nullable GIDAppCheckPrepareCompletion) - (void)getLimitedUseTokenWithCompletion:(nullable GIDAppCheckTokenCompletion)completion { dispatch_async(self.workerQueue, ^{ [self.appCheck limitedUseTokenWithCompletion:^(GACAppCheckTokenResult * _Nonnull result) { - if (result.token) { - [self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey]; - } + if (!result.error) { + [self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey]; + } if (completion) { completion(result.token, result.error); } From 239b0dedb8cef86eb5641d8bdefe30ed357b9858 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Fri, 21 Aug 2026 16:44:48 -0700 Subject: [PATCH 03/13] podspec testing --- .github/workflows/unit_tests.yml | 2 +- GoogleSignIn.podspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 67c9fd09..ee34bd27 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -36,7 +36,7 @@ jobs: # See #400 (https://github.com/google/GoogleSignIn-iOS/issues/400) run: | pod lib lint ${{ matrix.podspec }} --verbose \ - ${{ matrix.includePodspecFlag }} ${{ matrix.flag }} + ${{ matrix.includePodspecFlag }} ${{ matrix.flag }} --sources=https://github.com/firebase/SpecsDev.git,https://github.com/firebase/SpecsStaging.git,https://cdn.cocoapods.org/ spm-build-test: runs-on: ${{ matrix.os }} strategy: diff --git a/GoogleSignIn.podspec b/GoogleSignIn.podspec index 742534cd..5ebd148b 100644 --- a/GoogleSignIn.podspec +++ b/GoogleSignIn.podspec @@ -33,7 +33,7 @@ The Google Sign-In SDK allows users to sign in with their Google account from th ] s.ios.framework = 'UIKit' s.osx.framework = 'AppKit' - s.dependency 'AppCheckCore', '~> 11.0' + s.dependency 'AppCheckCore', '~> 12.0' s.dependency 'AppAuth', '~> 3.0' s.dependency 'GTMAppAuth', '~> 6.0' s.dependency 'GTMSessionFetcher/Core', '>= 3.3', '< 6.0' From 82b73317266e33032d15651e368bcd1e25b4a121 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Fri, 21 Aug 2026 17:29:09 -0700 Subject: [PATCH 04/13] Address code review findings in GIDAppCheck --- .../GIDAppCheck/Implementations/GIDAppCheck.m | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m b/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m index 8fb78dbe..58296beb 100644 --- a/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m +++ b/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m @@ -113,12 +113,6 @@ - (void)prepareForAppCheckWithCompletion:(nullable GIDAppCheckPrepareCompletion) [self.appCheck limitedUseTokenWithCompletion:^(GACAppCheckTokenResult * _Nonnull result) { NSError * __block maybeError = result.error; @synchronized (self) { - if (!result.token && !result.error) { - maybeError = [NSError errorWithDomain:kGIDAppCheckErrorDomain - code:kGIDAppCheckUnexpectedError - userInfo:nil]; - } - if (!result.error) { [self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey]; } @@ -139,9 +133,9 @@ - (void)prepareForAppCheckWithCompletion:(nullable GIDAppCheckPrepareCompletion) - (void)getLimitedUseTokenWithCompletion:(nullable GIDAppCheckTokenCompletion)completion { dispatch_async(self.workerQueue, ^{ [self.appCheck limitedUseTokenWithCompletion:^(GACAppCheckTokenResult * _Nonnull result) { - if (!result.error) { - [self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey]; - } + if (!result.error) { + [self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey]; + } if (completion) { completion(result.token, result.error); } From 3147ebb1a90ce88603374f3646667c8ac3f1f817 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 24 Sep 2026 14:25:27 -0400 Subject: [PATCH 05/13] appcheck 12 is now released --- Package.swift | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Package.swift b/Package.swift index 119f7842..03f18d99 100644 --- a/Package.swift +++ b/Package.swift @@ -44,10 +44,9 @@ let package = Package( .package( url: "https://github.com/openid/AppAuth-iOS.git", from: "3.0.0"), -// .package( -// url: "https://github.com/google/app-check.git", -// from: "11.0.0"), - .package(url: "https://github.com/google/app-check.git", branch: "pb-swift"), + .package( + url: "https://github.com/google/app-check.git", + "11.0.0" ..< "13.0.0"), .package( url: "https://github.com/google/GTMAppAuth.git", from: "6.0.0"), From 088b8f80948a8a0c532dd8a9998ad2a9a7c78883 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 24 Sep 2026 14:31:39 -0400 Subject: [PATCH 06/13] will revert: fix ci --- Samples/ObjC/SignInSample/Podfile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Samples/ObjC/SignInSample/Podfile b/Samples/ObjC/SignInSample/Podfile index 4f9e2cf2..b901d74f 100644 --- a/Samples/ObjC/SignInSample/Podfile +++ b/Samples/ObjC/SignInSample/Podfile @@ -1,3 +1,6 @@ +source 'https://github.com/firebase/SpecsStaging.git' +source 'https://cdn.cocoapods.org/' + platform :ios, '15.0' use_frameworks! From 52c164bac3a6cf04fdada0d2fbfe7218b05e2ae9 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 8 Oct 2026 10:04:29 -0400 Subject: [PATCH 07/13] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7703fa75..f4512028 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # Unreleased - Fix a crash when a server error response carries a non-string value under its `error` key. The EMM error handler sent `-hasPrefix:` to whatever value was present, raising an unrecognized selector exception on a number, array or object. - Fix a custom `nonce` and requested token `claims` being dropped when a sign-in is continued after a Device Policy app restart. +- Added Swift Package Manager support for AppCheckCore 12.x, enabling compatibility with Firebase 13. CocoaPods installations remain restricted to AppCheckCore 11.x # 10.0.0 - **BREAKING**: Update to AppAuth 3.0.0 and GTMAppAuth 6.0.0, which raises the minimum deployment targets to iOS 15.0 and macOS 12.0, widens the `GTMSessionFetcher` dependency to allow 4.x and 5.x, and renames the version-specific Swift Package Manager manifest to `Package@swift-5.7.swift`. Projects that must keep supporting earlier OS versions should stay on GoogleSignIn 9.2.0. ([#628](https://github.com/google/GoogleSignIn-iOS/pull/628)) From 34ed70668c2c76c8d40dd1f8a01718193b4d61e9 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 8 Oct 2026 10:09:37 -0400 Subject: [PATCH 08/13] Final cocoapods reversions Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com> --- .github/workflows/unit_tests.yml | 2 +- GoogleSignIn.podspec | 2 +- Samples/ObjC/SignInSample/Podfile | 3 --- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index c7c3f0b3..854a9c11 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -36,7 +36,7 @@ jobs: # See #400 (https://github.com/google/GoogleSignIn-iOS/issues/400) run: | pod lib lint ${{ matrix.podspec }} --verbose \ - ${{ matrix.includePodspecFlag }} ${{ matrix.flag }} --sources=https://github.com/firebase/SpecsDev.git,https://github.com/firebase/SpecsStaging.git,https://cdn.cocoapods.org/ + ${{ matrix.includePodspecFlag }} ${{ matrix.flag }} spm-build-test: runs-on: ${{ matrix.os }} strategy: diff --git a/GoogleSignIn.podspec b/GoogleSignIn.podspec index 5ebd148b..742534cd 100644 --- a/GoogleSignIn.podspec +++ b/GoogleSignIn.podspec @@ -33,7 +33,7 @@ The Google Sign-In SDK allows users to sign in with their Google account from th ] s.ios.framework = 'UIKit' s.osx.framework = 'AppKit' - s.dependency 'AppCheckCore', '~> 12.0' + s.dependency 'AppCheckCore', '~> 11.0' s.dependency 'AppAuth', '~> 3.0' s.dependency 'GTMAppAuth', '~> 6.0' s.dependency 'GTMSessionFetcher/Core', '>= 3.3', '< 6.0' diff --git a/Samples/ObjC/SignInSample/Podfile b/Samples/ObjC/SignInSample/Podfile index b901d74f..4f9e2cf2 100644 --- a/Samples/ObjC/SignInSample/Podfile +++ b/Samples/ObjC/SignInSample/Podfile @@ -1,6 +1,3 @@ -source 'https://github.com/firebase/SpecsStaging.git' -source 'https://cdn.cocoapods.org/' - platform :ios, '15.0' use_frameworks! From 4a6c9fbd9d0c6210ade5f9569a6e5dd7f1b76581 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 8 Oct 2026 12:14:49 -0400 Subject: [PATCH 09/13] Apply batched suggestions from code review Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com> --- GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m b/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m index 58296beb..ccdc3de3 100644 --- a/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m +++ b/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m @@ -111,7 +111,6 @@ - (void)prepareForAppCheckWithCompletion:(nullable GIDAppCheckPrepareCompletion) } [self.appCheck limitedUseTokenWithCompletion:^(GACAppCheckTokenResult * _Nonnull result) { - NSError * __block maybeError = result.error; @synchronized (self) { if (!result.error) { [self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey]; @@ -124,7 +123,7 @@ - (void)prepareForAppCheckWithCompletion:(nullable GIDAppCheckPrepareCompletion) for (GIDAppCheckPrepareCompletion savedCompletion in callbacks) { - savedCompletion(maybeError); + savedCompletion(result.error); } }]; }); From 737d9c56f323179e33405cd21053aedd152404d7 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Thu, 8 Oct 2026 09:15:44 -0700 Subject: [PATCH 10/13] Add CI to test with pre-Firebase 13 --- .github/workflows/builds.yml | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index e215d112..c2cf7d3d 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -37,6 +37,42 @@ jobs: -scheme GoogleSignIn-Package \ -destination "platform=OS X" + spm-app-check-11: + # Package.swift accepts app-check 11.x and 12.x, but Package.resolved is gitignored, so + # spm-build-test always gets the newest (12.x). Pin the latest 11.x (what Firebase 12 + # apps resolve) to keep SPM + AppCheckCore 11 covered. iOS only: all App Check code is + # behind TARGET_OS_IOS && !TARGET_OS_MACCATALYST. + runs-on: macos-15 + steps: + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + - name: Select Xcode + run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer + - name: Pin app-check to the latest 11.x + run: | + version=$(git ls-remote --tags --refs https://github.com/google/app-check.git '11.*' \ + | sed 's|.*refs/tags/||' | sort -V | tail -1) + echo "Pinning app-check $version" + # `resolve --version` can only re-pin an already-resolved dependency. + swift package resolve + swift package resolve app-check --version "$version" + - name: Build unit test target + run: | + xcodebuild \ + -scheme GoogleSignIn-Package \ + -sdk iphonesimulator \ + -destination "platform=iOS Simulator,name=iPhone 16,OS=18.6" \ + -onlyUsePackageVersionsFromResolvedFile \ + build-for-testing + - name: Run unit test target + run: | + xcodebuild \ + -scheme GoogleSignIn-Package \ + -sdk iphonesimulator \ + -destination "platform=iOS Simulator,name=iPhone 16,OS=18.6" \ + -onlyUsePackageVersionsFromResolvedFile \ + test-without-building + + xcode-27-preview-archive: # Archive every supported platform against the Xcode 27 preview image. The # image is preview, so this job does not block merges. From 01187158b8a490e12df72b2d1c61cb79e5a0b098 Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Thu, 8 Oct 2026 09:24:22 -0700 Subject: [PATCH 11/13] changelog nit --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f4512028..5864bdaf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Unreleased - Fix a crash when a server error response carries a non-string value under its `error` key. The EMM error handler sent `-hasPrefix:` to whatever value was present, raising an unrecognized selector exception on a number, array or object. - Fix a custom `nonce` and requested token `claims` being dropped when a sign-in is continued after a Device Policy app restart. -- Added Swift Package Manager support for AppCheckCore 12.x, enabling compatibility with Firebase 13. CocoaPods installations remain restricted to AppCheckCore 11.x +- Add Swift Package Manager support for AppCheckCore 12.x, enabling compatibility with Firebase 13. CocoaPods installations remain restricted to AppCheckCore 11.x # 10.0.0 - **BREAKING**: Update to AppAuth 3.0.0 and GTMAppAuth 6.0.0, which raises the minimum deployment targets to iOS 15.0 and macOS 12.0, widens the `GTMSessionFetcher` dependency to allow 4.x and 5.x, and renames the version-specific Swift Package Manager manifest to `Package@swift-5.7.swift`. Projects that must keep supporting earlier OS versions should stay on GoogleSignIn 9.2.0. ([#628](https://github.com/google/GoogleSignIn-iOS/pull/628)) From 794b8f6493e98dc17a8a673ba1904261c8e389ec Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 8 Oct 2026 12:45:33 -0400 Subject: [PATCH 12/13] Apply batched suggestions from code review Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com> --- .github/workflows/builds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index c2cf7d3d..12222fe3 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -60,7 +60,7 @@ jobs: xcodebuild \ -scheme GoogleSignIn-Package \ -sdk iphonesimulator \ - -destination "platform=iOS Simulator,name=iPhone 16,OS=18.6" \ + -destination "platform=iOS Simulator,name=iPhone 16,OS=18.5" \ -onlyUsePackageVersionsFromResolvedFile \ build-for-testing - name: Run unit test target @@ -68,7 +68,7 @@ jobs: xcodebuild \ -scheme GoogleSignIn-Package \ -sdk iphonesimulator \ - -destination "platform=iOS Simulator,name=iPhone 16,OS=18.6" \ + -destination "platform=iOS Simulator,name=iPhone 16,OS=18.5" \ -onlyUsePackageVersionsFromResolvedFile \ test-without-building From d014c3b01c3e5baf97f22df1ca3a0f5b3f9d10bb Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 8 Oct 2026 12:49:39 -0400 Subject: [PATCH 13/13] Apply suggestion from @ncooke3 --- .github/workflows/builds.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index 12222fe3..21e07d69 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -60,7 +60,7 @@ jobs: xcodebuild \ -scheme GoogleSignIn-Package \ -sdk iphonesimulator \ - -destination "platform=iOS Simulator,name=iPhone 16,OS=18.5" \ + -destination "platform=iOS Simulator,name=iPhone 16" \ -onlyUsePackageVersionsFromResolvedFile \ build-for-testing - name: Run unit test target