From 0fc30976ead8d316338ef359c84039abc0f244fc Mon Sep 17 00:00:00 2001 From: Iliya Lyan <68940374+12ya@users.noreply.github.com> Date: Wed, 21 May 2025 07:25:58 +0900 Subject: [PATCH] replace append with slices methods where applies --- bind/bind_test.go | 4 +++- cmd/gomobile/build.go | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/bind/bind_test.go b/bind/bind_test.go index 96288a4e2..8b15325b3 100644 --- a/bind/bind_test.go +++ b/bind/bind_test.go @@ -21,9 +21,11 @@ import ( "path" "path/filepath" "runtime" + "slices" "strings" "testing" + "golang.org/x/exp/slices" "golang.org/x/mobile/internal/importers" "golang.org/x/mobile/internal/importers/java" "golang.org/x/mobile/internal/importers/objc" @@ -287,7 +289,7 @@ func genJavaPackages(t *testing.T, dir string, cg *ClassGen) { func TestGenJava(t *testing.T) { allTests := tests if java.IsAvailable() { - allTests = append(append([]string{}, allTests...), javaTests...) + allTests = slices.Concat(allTests, javaTests) } for _, filename := range allTests { var pkg *types.Package diff --git a/cmd/gomobile/build.go b/cmd/gomobile/build.go index a8f0ad2cc..e74b22911 100644 --- a/cmd/gomobile/build.go +++ b/cmd/gomobile/build.go @@ -14,6 +14,7 @@ import ( "os" "os/exec" "regexp" + "slices" "strconv" "strings" @@ -338,7 +339,7 @@ func goCmdAt(at string, subcmd string, srcs []string, env []string, args ...stri if gmc, err := goModCachePath(); err == nil { env = append([]string{"GOMODCACHE=" + gmc}, env...) } else { - env = append([]string{}, env...) + env = slices.Clone(env) } cmd.Env = env cmd.Dir = at @@ -356,7 +357,7 @@ func goModTidyAt(at string, env []string) error { if gmc, err := goModCachePath(); err == nil { env = append([]string{"GOMODCACHE=" + gmc}, env...) } else { - env = append([]string{}, env...) + env = slices.Clone(env) } cmd.Env = env cmd.Dir = at