Skip to content

Commit 2ae793e

Browse files
tmm1thanm
authored andcommitted
cmd/link/internal/ld: ensure mach-o debug symbols are visible to App Store
Passing test that shows Apple's symbols utility can now read DWARF data in go.o, after the fix in CL174538 Updates #31022 #22716 #31459 Change-Id: I56c3517ad6d0a9f39537182f63cef56bb198aa83 Reviewed-on: https://go-review.googlesource.com/c/go/+/170451 Reviewed-by: Than McIntosh <[email protected]>
1 parent a0c96a9 commit 2ae793e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/cmd/link/dwarf_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string)
9898
if bytes.HasPrefix(out, []byte("Unable to find file")) {
9999
// This failure will cause the App Store to reject our binaries.
100100
t.Fatalf("symbols %v: failed to parse file", filepath.Base(exe))
101+
} else if bytes.Contains(out, []byte(", Empty]")) {
102+
t.Fatalf("symbols %v: parsed as empty", filepath.Base(exe))
101103
}
102104
}
103105
}

0 commit comments

Comments
 (0)