PolygonBuilder

[missinglink]

Heya,

I noticed that this library doesn't yet include the s2.PolygonBuilder but there is a working copy of it written in Go over on @davidreynolds repo here:

https://github.com/davidreynolds/gos2/blob/master/s2/polygonbuilder.go

I started porting it over and got most of the way there, would there be value in opening a pull request to migrate it?

[thinkovation]

Yes, I think so. From our perspective it's nice to be associated with contributions to OSS projects, more specifically from your perspective it's very cool for your developer cred to have made a contribution. G

…

On Fri, 11 Sep 2020 at 08:49, Peter Johnson ***@***.***> wrote: Heya, I noticed that this library doesn't yet include the s2.PolygonBuilder but there is a working copy of it written in Go over on @davidreynolds <https://github.com/davidreynolds> repo here: https://github.com/davidreynolds/gos2/blob/master/s2/polygonbuilder.go I started porting it over and got most of the way there, would there be value in opening a pull request to migrate it? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#71>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUQ5ROEIOP3DT4RIY4K5DDSFHJB3ANCNFSM4RG3MFZA> .

[missinglink]

@thinkovation when you say 'our perspective' are you speaking as a representative of this project team?

[jmr]

S2PolygonBuilder was deprecated and has been removed from the C++ release. S2Builder is the new version.

https://github.com/google/s2geometry/blob/master/src/s2/s2builder.h

If you would like to port that, help would be appreciated.