Skip to content
This repository was archived by the owner on Jan 16, 2021. It is now read-only.

talksapp: Allow specifying branch for github url #482

Open
@smasher164

Description

@smasher164

Currently, non-master branches are not recognized on go-talks.appspot.com. gosrc/github.go hardcodes the master branch for the directory path. https://github.com/golang/gddo/blob/master/gosrc/github.go#L197

rawBase, err := url.Parse(expand("https://raw.github.com/{owner}/{repo}/master{dir}/", match))

Related issue: #464 (for docs)

This also leads to issues where the .slide file is presented but the assets are not retrieved. See this slide.
The ability to specify a specific branch would greatly benefit my project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions