Skip to content

Commit b87b3bc

Browse files
dmitshurgopherbot
authored andcommitted
cmd/gopherbot: copy Testing label, wait longer for CherryPickApproved
Testing is another label we actively use during backport review to indicate that a backport involves a fix to test code only. Copy it by default too. Since cherry-pick issues to fix or skip broken or flaky tests may get approved well before their fix is developed, give such issues more time before auto-closing them as obsolete. Change-Id: Ia0645b08cd431e521d15ee97de19d12572c30dd1 Reviewed-on: https://go-review.googlesource.com/c/build/+/519376 Reviewed-by: Carlos Amedee <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]>
1 parent 6a5da5b commit b87b3bc

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

cmd/gopherbot/gopherbot.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1253,9 +1253,9 @@ func (b *gopherbot) closeStaleWaitingForInfo(ctx context.Context) error {
12531253
}
12541254

12551255
deadline := waitStart.AddDate(0, 1, 0) // 1 month
1256-
if gi.HasLabel("CherryPickCandidate") {
1257-
// Cherry-pick candidates may sometimes need to wait for fixes
1258-
// to soak on the order of months, so give them more time.
1256+
if gi.HasLabel("CherryPickCandidate") || gi.HasLabel("CherryPickApproved") {
1257+
// Cherry-pick issues may sometimes need to wait while
1258+
// fixes get prepared and soak, so give them more time.
12591259
deadline = waitStart.AddDate(0, 6, 0)
12601260
}
12611261
if now.Before(deadline) {
@@ -1728,6 +1728,7 @@ func (b *gopherbot) openCherryPickIssues(ctx context.Context) error {
17281728
for _, l := range [...]string{
17291729
"Security",
17301730
"GoCommand",
1731+
"Testing",
17311732
} {
17321733
if gi.HasLabel(l) {
17331734
extraLabels = append(extraLabels, l)

0 commit comments

Comments
 (0)