Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
VojtechVitek opened this issue Feb 23, 2025 · 1 comment
Open

Feedback #1

VojtechVitek opened this issue Feb 23, 2025 · 1 comment

Comments

@VojtechVitek
Copy link
Contributor

VojtechVitek commented Feb 23, 2025

  1. Concise mode should print flat fields only, e.g. req_headers="", resp_body, resp_bytes, resp_status
    • Consider renaming to "Verbose" / "Flat" etc.? It's not that this would be useful for development only -- it's the opposite, it's because we need a "flat" and "consise" log output for log collectors/ingestion.
  2. Consider splitting httplog.Handler into httplog.NewConciseHandler()/httplog.NewFlatHandler()/httplog.NewVerboseHandler() etc. and make it an explicit dependency into the httplog.Options.. .r.Use(httplog.RequestLogger(slog.Default(), &httplog.Options{
  3. Remove response.duration: 0 ?
  4. Do we need to implement Handler.WithGroup() ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant