-
Notifications
You must be signed in to change notification settings - Fork 141
[discussion]: Support for localhost domains & removing validations in login #777
Description
Topic
Should we add support for localhost URL support in the login command?
Context
I have been creating a one-click harbor + harbor-satellite setup on my computer in k8s. The harbor instance runs as a helm on k3d, such that the local url is localhost:8080 for me.
If i try to use harbor-cli to login and possibly use to manipulate my registry it doesnt allow me to proceed with the server since its 'not valid'.
Another point is that harbor-cli does not allow writing passwords that dont have an uppercase letters. On a fresh harbor setup the config file (or flags for helm) take any password for input, regardless of the regular validations. The harbor UI, allows any password's for login, it only enforces validations on user creation / password creation. I think that we should follow that practice as well.
Possible Ideas / Thoughts
Remove password validations, and just use the API errors to propagate back.
Allow support for localhost: url's.
Additional Information
# helm harbor setup
helm install harbor harbor/harbor \
--namespace harbor \
--create-namespace \
--set expose.type=nodePort \
--set expose.nodePort.ports.http.nodePort=30002 \
--set externalURL=http://localhost:8080 \ # This is the URL
--set harborAdminPassword=admin \ # Doesnt enforce password here
--set expose.tls.enabled=false