🤗 [Question]: Does fiber v3's Request not have the function of adding files to FormData?

[wnnce]

Question Description

I have an interface that needs to use FormData to upload files, but the AddFormDate() provided can only add strings, while AddFile() adds the file to the files field and not to the FormDate.

Code Snippet (optional)

var fiberClient *client.Client

func init() {
	fiberClient = client.New()
}

func uploadFile(fileName string, reader io.ReadCloser) {
	uploadToken := makeUploadToken(fileName, 1*time.Hour)
	formFile := client.AcquireFile(func(f *client.File) {
		f.SetName("file")
		f.SetFieldName(fileName)
		f.SetReader(reader)
	})
	request := client.AcquireRequest()
	request.AddFormData("key", fileName)
	request.AddFormData("token", uploadToken)
	request.AddFiles(formFile)
	response, err := request.Post(REGION)
	if err != nil {
		log.Fatalln(err)
	}
	fmt.Println(string(response.Body()))
}

Checklist:

• I agree to follow Fiber's Code of Conduct.
• I have checked for existing issues that describe my questions prior to opening this one.
• I understand that improperly formatted questions may be closed without explanation.

[welcome]

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[ReneWerner87]

@efectn can you help here

[wnnce]

@efectn can you help here

I implemented the requirement using fasthttp's multipart.NewWriter() and RawRequest

func upload(fileName string, reader io.ReadCloser) {
	uploadToken := makeUploadToken(fileName, 1*time.Hour)
	request := client.AcquireRequest()

	requestBody := &bytes.Buffer{}
	multipartWriter := multipart.NewWriter(requestBody)
	fileWriter, err := multipartWriter.CreateFormFile("file", fileName)
	if err != nil {
		log.Fatalln(err)
	}
	if _, err = io.Copy(fileWriter, reader); err != nil {
		log.Fatalln(err)
	}
	if err = multipartWriter.WriteField("key", fileName); err != nil {
		log.Fatalln(err)
	}
	if err = multipartWriter.WriteField("token", uploadToken); err != nil {
		log.Fatalln(err)
	}
	if err = multipartWriter.Close(); err != nil {
		log.Fatalln(err)
	}
	request.SetRawBody(requestBody.Bytes())
	request.AddHeader("Content-Type", multipartWriter.FormDataContentType())
	response, err := request.Post(REGION)
	if err != nil {
		log.Fatalln(err)
	}
	fmt.Println(string(response.Body()))
}

[carlos19960601]

same request here

[efectn]

What you want is already done at hooks stage https://github.com/gofiber/fiber/blob/main/client/hooks.go#L271 while sending the request. Which cases does this hook not cover? Do you want to get request body before sending the request? @carlos19960601 @wnnce

[gaby]

@wnnce io.Copy would load the whole thing to memory. Not ideal if the file is big.