Added functionalities to fix invalid cells and clear all cells in GridMap

Changes made:
* Added condition to `GridMap::set_mesh_library` to update only if new library is different from old one
* Added `GridMap::fix_invalid_cells` taking inspiration from `TileMap::fix_invalide_tiles`
* Added menu entry to clear cells in `GridMapEditor`
* Added menu entry to fix tiles in `GridMapEditor`

Author: simpuid

modules/gridmap/editor/grid_map_editor_plugin.cpp

@@ -238,6 +238,20 @@ void GridMapEditor::_menu_option(int p_option) {
 			_fill_selection();
 
 		} break;
+		case MENU_OPTION_CLEAR_ALL: {
+			undo_redo->create_action(TTR("Clear All"));
+			undo_redo->add_undo_method(node, "set", "data", node->get("data"));
+			node->clear();
+			undo_redo->add_do_method(node, "set", "data", node->get("data"));
+			undo_redo->commit_action();
+		} break;
+		case MENU_OPTION_FIX_INVALID_CELLS: {
+			undo_redo->create_action(TTR("Fix Invalid Cells"));
+			undo_redo->add_undo_method(node, "set", "data", node->get("data"));
+			node->fix_invalid_cells();
+			undo_redo->add_do_method(node, "set", "data", node->get("data"));
+			undo_redo->commit_action();
+		} break;
 		case MENU_OPTION_GRIDMAP_SETTINGS: {
 			settings_dialog->popup_centered(settings_vbc->get_combined_minimum_size() + Size2(50, 50) * EDSCALE);
 		} break;
@@ -1339,6 +1353,8 @@ GridMapEditor::GridMapEditor() {
 	ED_SHORTCUT("grid_map/edit_z_axis", TTRC("Edit Z Axis"), KeyModifierMask::SHIFT + Key::C, true);
 	ED_SHORTCUT("grid_map/keep_selected", TTRC("Keep Selection"));
 	ED_SHORTCUT("grid_map/clear_rotation", TTRC("Clear Rotation"));
+	ED_SHORTCUT("grid_map/clear_all", TTRC("Clear All"));
+	ED_SHORTCUT("grid_map/fix_invalid_cells", TTRC("Fix Invalid Cells"));
 
 	options = memnew(MenuButton);
 	options->set_theme_type_variation(SceneStringName(FlatButton));
@@ -1353,6 +1369,10 @@ GridMapEditor::GridMapEditor() {
 	options->get_popup()->add_check_shortcut(ED_GET_SHORTCUT("grid_map/keep_selected"), MENU_OPTION_PASTE_SELECTS);
 	options->get_popup()->set_item_checked(options->get_popup()->get_item_index(MENU_OPTION_PASTE_SELECTS), true);
 	options->get_popup()->add_separator();
+	options->get_popup()->add_shortcut(ED_SHORTCUT("grid_map/clear_all"), MENU_OPTION_CLEAR_ALL);
+	options->get_popup()->add_separator();
+	options->get_popup()->add_item(ED_SHORTCUT("grid_map/fix_invalid_cells"), MENU_OPTION_FIX_INVALID_CELLS);
+	options->get_popup()->add_separator();
 	options->get_popup()->add_item(TTR("Settings..."), MENU_OPTION_GRIDMAP_SETTINGS);
 
 	settings_dialog = memnew(ConfirmationDialog);

modules/gridmap/editor/grid_map_editor_plugin.h

@@ -202,6 +202,8 @@ class GridMapEditor : public VBoxContainer {
 		MENU_OPTION_SELECTION_CUT,
 		MENU_OPTION_SELECTION_CLEAR,
 		MENU_OPTION_SELECTION_FILL,
+		MENU_OPTION_CLEAR_ALL,
+		MENU_OPTION_FIX_INVALID_CELLS,
 		MENU_OPTION_GRIDMAP_SETTINGS
 
 	};

modules/gridmap/grid_map.cpp

@@ -267,12 +267,22 @@ RID GridMap::get_navigation_map() const {
 }
 
 void GridMap::set_mesh_library(const Ref<MeshLibrary> &p_mesh_library) {
-	if (mesh_library.is_valid()) {
-		mesh_library->disconnect_changed(callable_mp(this, &GridMap::_recreate_octant_data));
+	if (mesh_library != p_mesh_library) {
+		if (mesh_library.is_valid()) {
+			mesh_library->disconnect_changed(callable_mp(this, &GridMap::_recreate_octant_data));
+		}
+		mesh_library = p_mesh_library;
+		if (mesh_library.is_valid()) {
+			mesh_library->connect_changed(callable_mp(this, &GridMap::_recreate_octant_data));
+		}
+	}
+
+	if (!mesh_library.is_null()) {
+		mesh_library->unregister_owner(this);
 	}
 	mesh_library = p_mesh_library;
-	if (mesh_library.is_valid()) {
-		mesh_library->connect_changed(callable_mp(this, &GridMap::_recreate_octant_data));
+	if (!mesh_library.is_null()) {
+		mesh_library->register_owner(this);
 	}
 
 	_recreate_octant_data();
@@ -1130,6 +1140,8 @@ void GridMap::_bind_methods() {
 	ClassDB::bind_method(D_METHOD("clear_baked_meshes"), &GridMap::clear_baked_meshes);
 	ClassDB::bind_method(D_METHOD("make_baked_meshes", "gen_lightmap_uv", "lightmap_uv_texel_size"), &GridMap::make_baked_meshes, DEFVAL(false), DEFVAL(0.1));
 
+	ClassDB::bind_method(D_METHOD("fix_invalid_cells"), &GridMap::fix_invalid_cells);
+
 	ADD_PROPERTY(PropertyInfo(Variant::OBJECT, "mesh_library", PROPERTY_HINT_RESOURCE_TYPE, "MeshLibrary"), "set_mesh_library", "get_mesh_library");
 	ADD_PROPERTY(PropertyInfo(Variant::OBJECT, "physics_material", PROPERTY_HINT_RESOURCE_TYPE, "PhysicsMaterial"), "set_physics_material", "get_physics_material");
 	ADD_GROUP("Cell", "cell_");
@@ -1342,6 +1354,16 @@ RID GridMap::get_bake_mesh_instance(int p_idx) {
 	return baked_meshes[p_idx].instance;
 }
 
+void GridMap::fix_invalid_cells() {
+	ERR_FAIL_COND_MSG(mesh_library.is_null(), "Cannot fix invalid cells if MeshLibrary is not open.");
+
+	for (Map<IndexKey, Cell>::Element *E = cell_map.front(); E; E = E->next()) {
+		if (!mesh_library.is_valid() || !mesh_library->has_item(E->value().item)) {
+			set_cell_item(E->key().x, E->key().y, E->key().z, INVALID_CELL_ITEM);
+		}
+	}
+}
+
 GridMap::GridMap() {
 	set_notify_transform(true);
 #ifdef DEBUG_ENABLED

modules/gridmap/grid_map.h

@@ -302,6 +302,8 @@ class GridMap : public Node3D {
 	Array get_bake_meshes();
 	RID get_bake_mesh_instance(int p_idx);
 
+	void fix_invalid_cells();
+
 private:
 	static Callable _navmesh_source_geometry_parsing_callback;
 	static RID _navmesh_source_geometry_parser;