Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot-cpp Array API does not feature begin/end functions #1710

Open
AndrejLapin opened this issue Feb 18, 2025 · 1 comment
Open

Godot-cpp Array API does not feature begin/end functions #1710

AndrejLapin opened this issue Feb 18, 2025 · 1 comment
Labels
enhancement This is an enhancement on the current functionality
Milestone

Comments

@AndrejLapin
Copy link

Godot version

4.3 (99d66b4)

godot-cpp version

4.3 (f3a1a2f)

System information

Windows 10

Issue description

Godot-cpp gen/include/godot_cpp/variant/array.hpp API does not feature begin and end functions, when the same version of godot has such functions: https://github.com/godotengine/godot/blob/4.3/core/variant/array.h#L107-L111
Is this a generation issue?
Would be good to have begin and end accessible.

Steps to reproduce

  • run scons in godot-cpp project root

OR

  • run scons in native extension root that contains SConstruct file that uses godot-cpp scons environment.

Minimal reproduction project

Can be reproduced in godot-cpp repository.

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Feb 19, 2025
@dsnopek dsnopek added this to the 4.x milestone Feb 19, 2025
@dsnopek
Copy link
Collaborator

dsnopek commented Feb 19, 2025

I'd really love to have these in godot-cpp as well!

I actually didn't notice/remember that PR godotengine/godot#86518 got merged - I thought we were still waiting for that one before making the same change in godot-cpp.

This will need to be done at least partially in the code generator, because array.hpp is generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

No branches or pull requests

2 participants