Clippy

Complaints:
* items_after_test_module - projection.rs; `mod test` should come last.
* unnecessary_fallible_conversions - array_test.rs; TryFrom with Infallible should be replaced with From.

Author: Bromeon

godot-core/src/builtin/projection.rs

@@ -578,6 +578,54 @@ pub enum ProjectionEye {
     Right = 2,
 }
 
+impl std::fmt::Display for Projection {
+    /// Formats `Projection` to match Godot's string representation.
+    ///
+    /// Example:
+    /// ```
+    /// use godot::prelude::*;
+    /// let proj = Projection::new([
+    ///     Vector4::new(1.0, 2.5, 1.0, 0.5),
+    ///     Vector4::new(0.0, 1.5, 2.0, 0.5),
+    ///     Vector4::new(0.0, 0.0, 3.0, 2.5),
+    ///     Vector4::new(3.0, 1.0, 4.0, 1.5),
+    /// ]);
+    /// const FMT_RESULT: &str = r"
+    /// 1, 0, 0, 3
+    /// 2.5, 1.5, 0, 1
+    /// 1, 2, 3, 4
+    /// 0.5, 0.5, 2.5, 1.5
+    /// ";
+    /// assert_eq!(format!("{}", proj), FMT_RESULT);
+    /// ```
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "\n{}, {}, {}, {}\n{}, {}, {}, {}\n{}, {}, {}, {}\n{}, {}, {}, {}\n",
+            // first row
+            self.cols[0][Vector4Axis::X],
+            self.cols[1][Vector4Axis::X],
+            self.cols[2][Vector4Axis::X],
+            self.cols[3][Vector4Axis::X],
+            // second row
+            self.cols[0][Vector4Axis::Y],
+            self.cols[1][Vector4Axis::Y],
+            self.cols[2][Vector4Axis::Y],
+            self.cols[3][Vector4Axis::Y],
+            // third row
+            self.cols[0][Vector4Axis::Z],
+            self.cols[1][Vector4Axis::Z],
+            self.cols[2][Vector4Axis::Z],
+            self.cols[3][Vector4Axis::Z],
+            // forth row
+            self.cols[0][Vector4Axis::W],
+            self.cols[1][Vector4Axis::W],
+            self.cols[2][Vector4Axis::W],
+            self.cols[3][Vector4Axis::W],
+        )
+    }
+}
+
 #[cfg(test)]
 mod test {
     // TODO(bromeon): reduce code duplication
@@ -1033,51 +1081,3 @@ mod test {
         crate::builtin::test_utils::roundtrip(&projection, expected_json);
     }
 }
-
-impl std::fmt::Display for Projection {
-    /// Formats `Projection` to match Godot's string representation.
-    ///
-    /// Example:
-    /// ```
-    /// use godot::prelude::*;
-    /// let proj = Projection::new([
-    ///     Vector4::new(1.0, 2.5, 1.0, 0.5),
-    ///     Vector4::new(0.0, 1.5, 2.0, 0.5),
-    ///     Vector4::new(0.0, 0.0, 3.0, 2.5),
-    ///     Vector4::new(3.0, 1.0, 4.0, 1.5),
-    /// ]);
-    /// const FMT_RESULT: &str = r"
-    /// 1, 0, 0, 3
-    /// 2.5, 1.5, 0, 1
-    /// 1, 2, 3, 4
-    /// 0.5, 0.5, 2.5, 1.5
-    /// ";
-    /// assert_eq!(format!("{}", proj), FMT_RESULT);
-    /// ```
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        write!(
-            f,
-            "\n{}, {}, {}, {}\n{}, {}, {}, {}\n{}, {}, {}, {}\n{}, {}, {}, {}\n",
-            // first row
-            self.cols[0][Vector4Axis::X],
-            self.cols[1][Vector4Axis::X],
-            self.cols[2][Vector4Axis::X],
-            self.cols[3][Vector4Axis::X],
-            // second row
-            self.cols[0][Vector4Axis::Y],
-            self.cols[1][Vector4Axis::Y],
-            self.cols[2][Vector4Axis::Y],
-            self.cols[3][Vector4Axis::Y],
-            // third row
-            self.cols[0][Vector4Axis::Z],
-            self.cols[1][Vector4Axis::Z],
-            self.cols[2][Vector4Axis::Z],
-            self.cols[3][Vector4Axis::Z],
-            // forth row
-            self.cols[0][Vector4Axis::W],
-            self.cols[1][Vector4Axis::W],
-            self.cols[2][Vector4Axis::W],
-            self.cols[3][Vector4Axis::W],
-        )
-    }
-}

itest/rust/src/builtin_tests/containers/array_test.rs

@@ -78,6 +78,8 @@ fn array_from_slice() {
 #[itest]
 fn array_try_into_vec() {
     let array = array![1, 2];
+
+    #[allow(clippy::unnecessary_fallible_conversions)]
     let result = Vec::<i64>::try_from(&array);
     assert_eq!(result, Ok(vec![1, 2]));
 }