findPromotions: ignore users not in retrieved list (#19)

* findPromotions: ignore users not in retrieved list

* Document the bugfix for #16

Author: tarkatronic

CHANGELOG.md

@@ -1,5 +1,7 @@
 # `orglinter`
 
+- Fixed #16 - New users were causing an error in findPromotions
+
 ## 0.1.0
 
 - Initial MVP release

src/lib/checkers.js

@@ -22,7 +22,7 @@ function findDemotions(configured, retrieved) {
 
 function findPromotions(configured, retrieved) {
   const promotions = Object.keys(configured).filter(
-    (member) => configured[member] === 'ADMIN' && retrieved[member].role === 'MEMBER'
+    (member) => configured[member] === 'ADMIN' && retrieved[member] && retrieved[member].role === 'MEMBER'
   );
   console.log(`${promotions.length} promotions found: `, promotions);
   return promotions;

test/checkers.spec.js

@@ -51,6 +51,14 @@ describe('Checkers', function () {
       );
       assume(result).eqls(['zaphod']);
     });
+
+    it('ignores users not in retrieved list', function () {
+      const result = checkers.findPromotions(
+        { zaphod: 'ADMIN', trillian: 'ADMIN', marvin: 'MEMBER', ford: 'MEMBER' },
+        { zaphod: { role: 'MEMBER' }, marvin: { role: 'MEMBER' }, ford: { role: 'MEMBER' } }
+      );
+      assume(result).eqls(['zaphod']);
+    });
   });
 
   describe('validateTwoFactor', function () {