Add HTTPDriver interface and chromedp implementation #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwinter
commented
Jan 30, 2024
| // ... | ||
| // c.Visit("https://google.ca") | ||
| // } | ||
| func (c *Collector) Appengine(ctx context.Context) { |
Author
There was a problem hiding this comment.
Should use the functinal options instead
colly.NewCollector(
SetHTTPDriver(NewAppEngineBackend(ctx))
)
markwinter
changed the title
|
@markwinter Why was your PR closed? Was it merged somewhere else? Appreciate it. |
Author
|
@marcalc Just because I didn't think it would be merged and didn't want to keep it up to date |
Member
|
@markwinter This would be a very useful addition & the PR is clean. We are trying to find maintainers to resurrect the project and keep it well maintained. I'd appreciate a lot if you could rebase it one last time. Sorry for the long delayed response. |
Author
|
@asciimoo Thanks for the feedback, I will rebase and open the PR again |
Author
|
Opened a new MR here #844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased the previous PR as it had gotten stale #503 and I think several people are eager to use colly with chromedp
Will look to add tests and fix any builds. Can also squash commits when ready