Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charsets in the DSN Config is lowercase and cannot be used #1664

Open
modelorona opened this issue Jan 25, 2025 · 2 comments
Open

Charsets in the DSN Config is lowercase and cannot be used #1664

modelorona opened this issue Jan 25, 2025 · 2 comments

Comments

@modelorona
Copy link

modelorona commented Jan 25, 2025 •
edited
Loading

mysql/dsn.go

Line 47 in 85c6311

charsets []string // Connection charset. When set, this will be set in SET NAMES <charset> query

Based on the README docs, shouldn't this be capitalized as to let it be used?
@methane
Copy link
Member

methane commented Jan 27, 2025

I don't like the charsets list.
I will provide functional option for charset.

@modelorona
Copy link
Author

Cool, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@methane @modelorona