From 2f69712cd480487ecb7e513b2fe1e0e7fe138767 Mon Sep 17 00:00:00 2001 From: Inada Naoki Date: Sun, 16 Jun 2024 10:18:42 +0900 Subject: [PATCH] fix unnecesssary allocation in infile.go (#1600) --- infile.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/infile.go b/infile.go index 0c8af9f11..cf892beae 100644 --- a/infile.go +++ b/infile.go @@ -95,7 +95,6 @@ const defaultPacketSize = 16 * 1024 // 16KB is small enough for disk readahead a func (mc *okHandler) handleInFileRequest(name string) (err error) { var rdr io.Reader - var data []byte packetSize := defaultPacketSize if mc.maxWriteSize < packetSize { packetSize = mc.maxWriteSize @@ -147,9 +146,11 @@ func (mc *okHandler) handleInFileRequest(name string) (err error) { } // send content packets + var data []byte + // if packetSize == 0, the Reader contains no data if err == nil && packetSize > 0 { - data := make([]byte, 4+packetSize) + data = make([]byte, 4+packetSize) var n int for err == nil { n, err = rdr.Read(data[4:])