fix: handle first release GetCommits correctly

Author: christophwitzko

pkg/provider/github.go

@@ -83,8 +83,8 @@ func (repo *GitHubRepository) GetInfo() (*provider.RepositoryInfo, error) {
 	}, nil
 }
 
-func (repo *GitHubRepository) getCommitsFromGithub(fromSha, toSha string, opts *github.ListOptions) ([]*github.RepositoryCommit, *github.Response, error) {
-	if !repo.compareCommits {
+func (repo *GitHubRepository) getCommitsFromGithub(compareCommits bool, fromSha, toSha string, opts *github.ListOptions) ([]*github.RepositoryCommit, *github.Response, error) {
+	if !compareCommits {
 		return repo.client.Repositories.ListCommits(context.Background(), repo.owner, repo.repo, &github.CommitsListOptions{
 			SHA:         toSha,
 			ListOptions: *opts,
@@ -98,17 +98,23 @@ func (repo *GitHubRepository) getCommitsFromGithub(fromSha, toSha string, opts *
 }
 
 func (repo *GitHubRepository) GetCommits(fromSha, toSha string) ([]*semrel.RawCommit, error) {
+	compareCommits := repo.compareCommits
+	if compareCommits && fromSha == "" {
+		// we want all commits for the first release, hence disable compareCommits
+		compareCommits = false
+	}
 	allCommits := make([]*semrel.RawCommit, 0)
 	opts := &github.ListOptions{PerPage: 100}
 	done := false
 	for {
-		commits, resp, err := repo.getCommitsFromGithub(fromSha, toSha, opts)
+		commits, resp, err := repo.getCommitsFromGithub(compareCommits, fromSha, toSha, opts)
 		if err != nil {
 			return nil, err
 		}
 		for _, commit := range commits {
 			sha := commit.GetSHA()
-			if sha == fromSha {
+			// compare commits already returns the relevant commits and no extra filtering is needed
+			if !compareCommits && sha == fromSha {
 				done = true
 				break
 			}
@@ -122,7 +128,6 @@ func (repo *GitHubRepository) GetCommits(fromSha, toSha string) ([]*semrel.RawCo
 		}
 		opts.Page = resp.NextPage
 	}
-
 	return allCommits, nil
 }
 

pkg/provider/github_test.go

@@ -104,15 +104,18 @@ func githubHandler(w http.ResponseWriter, r *http.Request) {
 	if r.Method == "GET" && strings.HasPrefix(r.URL.Path, "/repos/owner/test-repo/compare/") {
 		li := strings.LastIndex(r.URL.Path, "/")
 		shaRange := strings.Split(r.URL.Path[li+1:], "...")
+		fromSha := shaRange[0]
 		toSha := shaRange[1]
-		skip := 0
+		start := 0
+		end := 0
 		for i, commit := range GITHUB_COMMITS {
 			if commit.GetSHA() == toSha {
-				skip = i
-				break
+				start = i
+			} else if commit.GetSHA() == fromSha {
+				end = i
 			}
 		}
-		json.NewEncoder(w).Encode(github.CommitsComparison{Commits: GITHUB_COMMITS[skip:]})
+		json.NewEncoder(w).Encode(github.CommitsComparison{Commits: GITHUB_COMMITS[start:end]})
 		return
 	}
 	if r.Method == "GET" && r.URL.Path == "/repos/owner/test-repo/commits" {