Can't click on re-run action job until all done

[xlazom00]

Description

User can't click on re-run button when something is running. This is really a issue when we want to rerun multiple failed jobs.

on:
  push:
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - run: echo "This job is now running on a ${{ runner.os }} server"
  test:
    needs: build
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
      max-parallel: 3
      matrix:
        ci_index: [0, 1]
    steps:
    - run: echo "This job is now running on a ${{ runner.os }} server"
    - name: Sleep 
      run: |
        delay=$(( ${{ matrix.ci_index }} * 5 ))
        sleep "${delay}"
    - name: error 
      run: |
        exit 1

Steps to reproduce:

1. use provided yaml
2. run actions

3. click rerun on test (0)
4. can't click rerun on test (1)

Expected behavior:
User should be able to click on multiple failed jobs one after another.
For now when I press re-run on 0. failed job I can't click on re-run on 1. And I need to wail until all done.
I think that rerun buttons should be available all the time.

Gitea Version

1.25.4

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

windows

How are you running Gitea?

I did test it on https://demo.gitea.com/

Database

SQLite

[silverwind]

I think making that button always visible would be confusing to users because restarting a running job is a uncommon action.

I think that such functionality can be provided, but not on that specific button, maybe in another place or hidden inside a "..." menu.

[xlazom00]

@silverwind but now when two jobs failed from matrix I can only click on one.
I can't rerun all failed jobs at once.

[silverwind]

How does GitHub's UI solve this? Don't they provide either a "rerun all" or "rerun failed" button? If it's the latter, I can see us implementing that.

[xlazom00]

I don't know how github but gitlab allow to click rerun on all failed jobs at any time

[silverwind]

Github has these:

Would those satisfy your request?

[xlazom00]

That will be fine.
And what about re-run all the time on failed jobs ? That should be also easy.

[silverwind]

I don't understand, you mean retry on failure? that is something you have to implement yourself imho.

[xlazom00]

I do mean that when job is in failed state we should be able to click rerun button next to it. For now All rerun buttons will deseaper when something is running.
This is what happen when I click rerun button on 2. job. I can't click on rerun on 3. job

[RichardWepner]

@silverwind: as far as I understand @xlazom00, they'd like to have a retry button next to failed jobs. From the screenshots you can see that there are no rerun buttons (also not next to failed jobs) as soon as there is a single running job. This can either be the case if not all jobs finished, or if one of the jobs was rerun already. (If you have a pipeline with many failed jobs and you want to rerun exactly 2, you couldn't do that with a "rerun all failed" button.)

In my opinion, the biggest benefit would be achieved by having the buttons you showed from the Github UI: "rerun all" and "rerun all failed". Making the rerun button available on a per-job-level could still be approached (or evaluated) afterwards as well. (However, this is just my opinion.)

[silverwind]

I do mean that when job is in failed state we should be able to click rerun button next to it. For now All rerun buttons will deseaper when something is running. This is what happen when I click rerun button on 2. job. I can't click on rerun on 3. job

ah i understand. yes makes sense to immediately show rerun buttons there to rerun single actions.

[xlazom00]

Sometimes I don't want to rerun all failed jobs. Just some of them :)
More options will be better :)