Skip to content

Commit 571c2db

Browse files
committed
refactor(metrics)!: deprecate issues open/closed for labels
1 parent cb36081 commit 571c2db

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

modules/metrics/collector.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func NewCollector() Collector {
8989
Issues: prometheus.NewDesc(
9090
namespace+"issues",
9191
"Number of Issues",
92-
nil, nil,
92+
[]string{"state"}, nil,
9393
),
9494
IssuesByLabel: prometheus.NewDesc(
9595
namespace+"issues_by_label",
@@ -103,12 +103,12 @@ func NewCollector() Collector {
103103
),
104104
IssuesOpen: prometheus.NewDesc(
105105
namespace+"issues_open",
106-
"Number of open Issues",
106+
"DEPRECATED: Use Issues with state: open",
107107
nil, nil,
108108
),
109109
IssuesClosed: prometheus.NewDesc(
110110
namespace+"issues_closed",
111-
"Number of closed Issues",
111+
"DEPRECATED: Use Issues with state: closed",
112112
nil, nil,
113113
),
114114
Labels: prometheus.NewDesc(
@@ -272,8 +272,14 @@ func (c Collector) Collect(ch chan<- prometheus.Metric) {
272272
ch <- prometheus.MustNewConstMetric(
273273
c.Issues,
274274
prometheus.GaugeValue,
275-
float64(stats.Counter.Issue),
275+
float64(stats.Counter.IssueOpen), "open",
276+
)
277+
ch <- prometheus.MustNewConstMetric(
278+
c.Issues,
279+
prometheus.GaugeValue,
280+
float64(stats.Counter.IssueClosed), "closed",
276281
)
282+
277283
for _, il := range stats.Counter.IssueByLabel {
278284
ch <- prometheus.MustNewConstMetric(
279285
c.IssuesByLabel,

0 commit comments

Comments
 (0)