Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy copy/pasted code #127

Open
cjslep opened this issue Oct 21, 2019 · 0 comments
Open

Destroy copy/pasted code #127

cjslep opened this issue Oct 21, 2019 · 0 comments
Labels
hygiene Project health: cleanup, refactorings, tests, etc.

Comments

@cjslep
Copy link
Member

cjslep commented Oct 21, 2019 •
edited
Loading

As part of this change on two separate occasions I copied/pasted code in two places in the converter.go file. They're marked with TODOs

Each could be unified into a single function, I'm sure. But that file is already needing dear love.
@cjslep cjslep added the hygiene Project health: cleanup, refactorings, tests, etc. label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hygiene Project health: cleanup, refactorings, tests, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjslep