Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen comands update source #93

Open
1am opened this issue Apr 6, 2022 · 1 comment
Open

codegen comands update source #93

1am opened this issue Apr 6, 2022 · 1 comment

Comments

@1am
Copy link

1am commented Apr 6, 2022

Hello. Is there a source of json files for codegen https://github.com/go-ble/ble/blob/master/linux/tools/codegen/cmd.json ? I'm missing quite a few commands and was wondering where did the initial ones come from. Maybe they've been updated along Bluetooth spec updates over the years.

What puzzles me is that it comes from the same Github account, now deleted.
Screenshot from 2022-04-06 20-27-39

It's also the same account as made the commands in https://github.com/paypal/gatt/tree/master/linux/cmd
Screenshot from 2022-04-06 20-27-52

@estutzenberger
Copy link

Heya!

I didn't work on this code initially so I am uncertain of its history. As best I can tell, all of the JSON which generates the commands available in this library are in tools/codegen/*.json. If there are missing commands, I'm not aware of them or haven't needed them in anything that I've been working on. I'm happy to review a PR for missing commands if you wanted to update them.

As for the source of the files, my guess is they were added by hand directly from the Bluetooth specification. I'm not aware of any documents which provide the available command sets listed in the BT spec in a format that could be ingested and converted to meaningful JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants