File tree Expand file tree Collapse file tree 2 files changed +9
-8
lines changed Expand file tree Collapse file tree 2 files changed +9
-8
lines changed Original file line number Diff line number Diff line change
1
+ 2017-09-20 Ethan A Merritt <
[email protected] >
2
+
3
+ * term/cairo.trm (cairotrm_reset): Revert change.
4
+
1
5
2017-09-19 Ethan A Merritt <
[email protected] >
2
6
3
7
* term/cairo.trm (cairotrm_init cairotrm_reset): Valgrind complained
6
10
It does make sense to call it if the terminal has been closed and then
7
11
reopened. So we fix the ordering of code in cairotrm_init that
8
12
frees the old plot.cr before reinitializing a new one.
13
+ REVERT: This change caused some cairo installations to close pdf output
14
+ file without proper termination of the contents.
9
15
10
16
* src/parse.c (parse_array_assignment): Memory leak.
11
17
Original file line number Diff line number Diff line change 1
1
/* Hello, Emacs: this is -*-C-*- !
2
- * $Id: cairo.trm,v 1.80 2017-09-19 20:15:10 sfeam Exp $
2
+ * $Id: cairo.trm,v 1.81 2017-09-21 18:22:12 sfeam Exp $
3
3
*/
4
4
5
5
/* GNUPLOT - cairo.trm */
@@ -973,13 +973,8 @@ void cairotrm_text()
973
973
/* sent when gnuplot exits and when the terminal or the output change.*/
974
974
void cairotrm_reset ()
975
975
{
976
- /* Sep 2017
977
- * valgrind complains that this triggers reads of already-freed data.
978
- * It is unclear whether that is a real problem, but it is also unclear
979
- * that anything is gained by explicit cleanup when we are about to exit.
980
- * Let's try skipping it and see if anyone notices.
981
- */
982
- /* cairo_destroy(plot.cr); */
976
+ if (plot .cr )
977
+ cairo_destroy (plot .cr );
983
978
984
979
#ifdef PSLATEX_DRIVER
985
980
/* finish latex output */
You can’t perform that action at this time.
0 commit comments