Repository navigation
Expand file tree
/
Copy pathmessage_test.dart
More file actions
938 lines (835 loc) · 35.9 KB
/
Copy pathmessage_test.dart
File metadata and controls
938 lines (835 loc) · 35.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
import 'dart:convert';
import 'package:checks/checks.dart';
import 'package:test/scaffolding.dart';
import 'package:zulip/api/model/events.dart';
import 'package:zulip/api/model/model.dart';
import 'package:zulip/api/model/submessage.dart';
import 'package:zulip/model/message_list.dart';
import 'package:zulip/model/narrow.dart';
import 'package:zulip/model/store.dart';
import '../api/fake_api.dart';
import '../api/model/model_checks.dart';
import '../api/model/submessage_checks.dart';
import '../example_data.dart' as eg;
import '../stdlib_checks.dart';
import 'message_list_test.dart';
import 'store_checks.dart';
import 'test_store.dart';
void main() {
// These "late" variables are the common state operated on by each test.
// Each test case calls [prepare] to initialize them.
late Subscription subscription;
late PerAccountStore store;
late FakeApiConnection connection;
// [messageList] is here only for the sake of checking when it notifies.
// For anything deeper than that, use `message_list_test.dart`.
late MessageListView messageList;
late int notifiedCount;
void checkNotified({required int count}) {
check(notifiedCount).equals(count);
notifiedCount = 0;
}
void checkNotNotified() => checkNotified(count: 0);
void checkNotifiedOnce() => checkNotified(count: 1);
/// Initialize [store] and the rest of the test state.
Future<void> prepare({Narrow narrow = const CombinedFeedNarrow()}) async {
final stream = eg.stream(streamId: eg.defaultStreamMessageStreamId);
subscription = eg.subscription(stream);
store = eg.store();
await store.addStream(stream);
await store.addSubscription(subscription);
connection = store.connection as FakeApiConnection;
notifiedCount = 0;
messageList = MessageListView.init(store: store, narrow: narrow)
..addListener(() {
notifiedCount++;
});
check(messageList).fetched.isFalse();
checkNotNotified();
}
/// Perform the initial message fetch for [messageList].
///
/// The test case must have already called [prepare] to initialize the state.
///
/// This does not support submessages. Use [prepareMessageWithSubmessages]
/// instead if needed.
Future<void> prepareMessages(
List<Message> messages, {
bool foundOldest = false,
}) async {
assert(messages.every((message) => message.poll == null));
connection.prepare(json:
eg.newestGetMessagesResult(foundOldest: foundOldest, messages: messages).toJson());
await messageList.fetchInitial();
checkNotifiedOnce();
}
Future<void> addMessages(Iterable<Message> messages) async {
await store.addMessages(messages);
checkNotified(count: messageList.fetched ? messages.length : 0);
}
group('reconcileMessages', () {
test('from empty', () async {
await prepare();
check(store.messages).isEmpty();
final message1 = eg.streamMessage();
final message2 = eg.streamMessage();
final message3 = eg.dmMessage(from: eg.otherUser, to: [eg.selfUser]);
final messages = <Message>[message1, message2, message3];
store.reconcileMessages(messages);
check(messages).deepEquals(
[message1, message2, message3]
.map((m) => (Subject<Object?> it) => it.identicalTo(m)));
check(store.messages).deepEquals({
for (final m in messages) m.id: m,
});
});
test('from not-empty', () async {
await prepare();
final message1 = eg.streamMessage();
final message2 = eg.streamMessage();
final message3 = eg.dmMessage(from: eg.otherUser, to: [eg.selfUser]);
final messages = <Message>[message1, message2, message3];
await addMessages(messages);
final newMessage = eg.streamMessage();
store.reconcileMessages([newMessage]);
check(messages).deepEquals(
[message1, message2, message3]
.map((m) => (Subject<Object?> it) => it.identicalTo(m)));
check(store.messages).deepEquals({
for (final m in messages) m.id: m,
newMessage.id: newMessage,
});
});
test('on ID collision, new message does not clobber old in store.messages', () async {
await prepare();
final message = eg.streamMessage(id: 1, content: '<p>foo</p>');
await addMessages([message]);
check(store.messages).deepEquals({1: message});
final newMessage = eg.streamMessage(id: 1, content: '<p>bar</p>');
final messages = [newMessage];
store.reconcileMessages(messages);
check(messages).single.identicalTo(message);
check(store.messages).deepEquals({1: message});
});
});
group('handleMessageEvent', () {
test('from empty', () async {
await prepare();
check(store.messages).isEmpty();
final newMessage = eg.streamMessage();
await store.addMessage(newMessage);
check(store.messages).deepEquals({
newMessage.id: newMessage,
});
});
test('from not-empty', () async {
await prepare();
final messages = <Message>[
eg.streamMessage(),
eg.streamMessage(),
eg.dmMessage(from: eg.otherUser, to: [eg.selfUser]),
];
await addMessages(messages);
check(store.messages).deepEquals({
for (final m in messages) m.id: m,
});
final newMessage = eg.streamMessage();
await store.addMessage(newMessage);
check(store.messages).deepEquals({
for (final m in messages) m.id: m,
newMessage.id: newMessage,
});
});
test('new message clobbers old on ID collision', () async {
await prepare();
final message = eg.streamMessage(id: 1, content: '<p>foo</p>');
await addMessages([message]);
check(store.messages).deepEquals({1: message});
final newMessage = eg.streamMessage(id: 1, content: '<p>bar</p>');
await store.addMessage(newMessage);
check(store.messages).deepEquals({1: newMessage});
});
});
group('handleUpdateMessageEvent', () {
test('update timestamps on all messages', () async {
const t1 = 1718748879;
const t2 = t1 + 60;
final message1 = eg.streamMessage(lastEditTimestamp: null);
final message2 = eg.streamMessage(lastEditTimestamp: t1);
// This event is a bit artificial, but convenient.
// TODO use a realistic move-messages event here
final updateEvent = Event.fromJson({
...eg.updateMessageEditEvent(message1).toJson(),
'message_ids': [message1.id, message2.id],
'edit_timestamp': t2,
}) as UpdateMessageEvent;
await prepare();
await prepareMessages([message1, message2]);
check(store).messages.values.unorderedMatches(<Condition<Message>>[
(it) => it.lastEditTimestamp.isNull,
(it) => it.lastEditTimestamp.equals(t1),
]);
await store.handleEvent(updateEvent);
checkNotifiedOnce();
check(store).messages.values.unorderedMatches(<Condition<Message>>[
(it) => it.lastEditTimestamp.equals(t2),
(it) => it.lastEditTimestamp.equals(t2),
]);
});
test('update a message', () async {
final originalMessage = eg.streamMessage(
content: "<p>Hello, world</p>");
final updateEvent = eg.updateMessageEditEvent(originalMessage,
flags: [MessageFlag.starred],
renderedContent: "<p>Hello, edited</p>",
editTimestamp: 99999,
isMeMessage: true,
);
await prepare();
await prepareMessages([originalMessage]);
final message = store.messages.values.single;
check(message)
..content.not((it) => it.equals(updateEvent.renderedContent!))
..lastEditTimestamp.isNull()
..flags.not((it) => it.deepEquals(updateEvent.flags))
..isMeMessage.not((it) => it.equals(updateEvent.isMeMessage!))
..editState.equals(MessageEditState.none);
await store.handleEvent(updateEvent);
checkNotifiedOnce();
check(store).messages.values.single
..identicalTo(message)
..content.equals(updateEvent.renderedContent!)
..lastEditTimestamp.equals(updateEvent.editTimestamp)
..flags.equals(updateEvent.flags)
..isMeMessage.equals(updateEvent.isMeMessage!)
..editState.equals(MessageEditState.edited);
});
test('ignore when message unknown', () async {
final originalMessage = eg.streamMessage(
content: "<p>Hello, world</p>");
final updateEvent = eg.updateMessageEditEvent(originalMessage,
messageId: originalMessage.id + 1,
renderedContent: "<p>Hello, edited</p>",
);
await prepare();
await prepareMessages([originalMessage]);
await store.handleEvent(updateEvent);
checkNotNotified();
check(store).messages.values.single
..content.equals(originalMessage.content)
..content.not((it) => it.equals(updateEvent.renderedContent!));
});
// TODO(server-5): Cut legacy case for rendering-only message update
Future<void> checkRenderingOnly({required bool legacy}) async {
final originalMessage = eg.streamMessage(
lastEditTimestamp: 78492,
content: "<p>Hello, world</p>");
final updateEvent = eg.updateMessageEditEvent(originalMessage,
renderedContent: "<p>Hello, world</p> <div>Some link preview</div>",
editTimestamp: 99999,
renderingOnly: legacy ? null : true,
userId: null,
);
await prepare();
await prepareMessages([originalMessage]);
final message = store.messages.values.single;
await store.handleEvent(updateEvent);
checkNotifiedOnce();
check(store).messages.values.single
..identicalTo(message)
// Content is updated...
..content.equals(updateEvent.renderedContent!)
// ... edit timestamp is not.
..lastEditTimestamp.equals(originalMessage.lastEditTimestamp)
..lastEditTimestamp.not((it) => it.equals(updateEvent.editTimestamp));
}
test('rendering-only update does not change timestamp', () async {
await checkRenderingOnly(legacy: false);
});
test('rendering-only update does not change timestamp (for old server versions)', () async {
await checkRenderingOnly(legacy: true);
});
group('Handle message edit state update', () {
late List<StreamMessage> origMessages;
Future<void> prepareOrigMessages({
required String origTopic,
String? origContent,
}) async {
origMessages = List.generate(2, (i) => eg.streamMessage(
topic: origTopic,
content: origContent,
));
await prepare();
await prepareMessages(origMessages);
}
test('message not moved update', () async {
await prepareOrigMessages(origTopic: 'origTopic');
await store.handleEvent(eg.updateMessageEditEvent(origMessages[0]));
checkNotifiedOnce();
check(store).messages[origMessages[0].id].editState.equals(MessageEditState.edited);
check(store).messages[origMessages[1].id].editState.equals(MessageEditState.none);
});
test('message topic moved update', () async {
await prepareOrigMessages(origTopic: 'old topic');
final originalDisplayRecipient = origMessages[0].displayRecipient!;
await store.handleEvent(eg.updateMessageEventMoveFrom(
origMessages: origMessages,
newTopicStr: 'new topic'));
checkNotified(count: 2);
check(store).messages.values.every(((message) =>
message.isA<StreamMessage>()
..editState.equals(MessageEditState.moved)
..displayRecipient.equals(originalDisplayRecipient)));
});
test('message topic resolved update', () async {
await prepareOrigMessages(origTopic: 'new topic');
await store.handleEvent(eg.updateMessageEventMoveFrom(
origMessages: origMessages,
newTopicStr: '✔ new topic'));
checkNotified(count: 2);
check(store).messages.values.every(((message) => message.editState.equals(MessageEditState.none)));
});
test('message topic unresolved update', () async {
await prepareOrigMessages(origTopic: '✔ new topic');
await store.handleEvent(eg.updateMessageEventMoveFrom(
origMessages: origMessages,
newTopicStr: 'new topic'));
checkNotified(count: 2);
check(store).messages.values.every(((message) => message.editState.equals(MessageEditState.none)));
});
test('message topic both resolved and edited update', () async {
await prepareOrigMessages(origTopic: 'new topic');
await store.handleEvent(eg.updateMessageEventMoveFrom(
origMessages: origMessages,
newTopicStr: '✔ new topic 2'));
checkNotified(count: 2);
check(store).messages.values.every(((message) => message.editState.equals(MessageEditState.moved)));
});
test('message topic both unresolved and edited update', () async {
await prepareOrigMessages(origTopic: '✔ new topic');
await store.handleEvent(eg.updateMessageEventMoveFrom(
origMessages: origMessages,
newTopicStr: 'new topic 2'));
checkNotified(count: 2);
check(store).messages.values.every(((message) => message.editState.equals(MessageEditState.moved)));
});
test('message stream moved without topic change', () async {
await prepareOrigMessages(origTopic: 'topic');
await store.handleEvent(eg.updateMessageEventMoveFrom(
origMessages: origMessages,
newStreamId: 20));
checkNotified(count: 2);
check(store).messages.values.every(((message) =>
message.isA<StreamMessage>()
..editState.equals(MessageEditState.moved)
..displayRecipient.equals(null)));
});
test('message is both moved and updated', () async {
await prepareOrigMessages(origTopic: 'topic', origContent: 'old content');
await store.handleEvent(eg.updateMessageEventMoveFrom(
origMessages: origMessages,
newStreamId: 20,
newContent: 'new content'));
checkNotified(count: 2);
check(store).messages[origMessages[0].id].editState.equals(MessageEditState.edited);
check(store).messages[origMessages[1].id].editState.equals(MessageEditState.moved);
});
});
});
group('handleDeleteMessageEvent', () {
test('delete an unknown message', () async {
final message1 = eg.streamMessage();
final message2 = eg.streamMessage();
await prepare();
await prepareMessages([message1]);
await store.handleEvent(eg.deleteMessageEvent([message2]));
checkNotNotified();
check(store).messages.values.single.id.equals(message1.id);
});
test('delete messages', () async {
final message1 = eg.streamMessage();
final message2 = eg.streamMessage();
await prepare();
await prepareMessages([message1, message2]);
await store.handleEvent(eg.deleteMessageEvent([message1, message2]));
checkNotifiedOnce();
check(store).messages.isEmpty();
});
test('delete an unknown message with a known message', () async {
final message1 = eg.streamMessage();
final message2 = eg.streamMessage();
final message3 = eg.streamMessage();
await prepare();
await prepareMessages([message1, message2]);
await store.handleEvent(eg.deleteMessageEvent([message2, message3]));
checkNotifiedOnce();
check(store).messages.values.single.id.equals(message1.id);
});
});
group('handleUpdateMessageFlagsEvent', () {
UpdateMessageFlagsAddEvent mkAddEvent(
MessageFlag flag,
List<int> messageIds, {
bool all = false,
}) {
return UpdateMessageFlagsAddEvent(
id: 1,
flag: flag,
messages: messageIds,
all: all,
);
}
const mkRemoveEvent = eg.updateMessageFlagsRemoveEvent;
group('add flag', () {
test('message is unknown', () async {
await prepare();
final message = eg.streamMessage(flags: []);
await prepareMessages([message]);
await store.handleEvent(mkAddEvent(MessageFlag.read, [2]));
checkNotNotified();
check(store).messages.values.single.flags.deepEquals([]);
});
test('affected message, unaffected message, absent message', () async {
await prepare();
final message1 = eg.streamMessage(flags: []);
final message2 = eg.streamMessage(flags: []);
await prepareMessages([message1, message2]);
await store.handleEvent(mkAddEvent(MessageFlag.read, [message2.id, 3]));
checkNotifiedOnce();
check(store).messages
..[message1.id].flags.deepEquals([])
..[message2.id].flags.deepEquals([MessageFlag.read]);
});
test('all: true; we have some known messages', () async {
await prepare();
final message1 = eg.streamMessage(flags: []);
final message2 = eg.streamMessage(flags: []);
await prepareMessages([message1, message2]);
await store.handleEvent(mkAddEvent(MessageFlag.read, [], all: true));
checkNotifiedOnce();
check(store).messages
..[message1.id].flags.deepEquals([MessageFlag.read])
..[message2.id].flags.deepEquals([MessageFlag.read]);
});
test('all: true; we don\'t know about any messages', () async {
await prepare();
await prepareMessages([]);
await store.handleEvent(mkAddEvent(MessageFlag.read, [], all: true));
checkNotNotified();
});
test('other flags not clobbered', () async {
final message = eg.streamMessage(flags: [MessageFlag.starred]);
await prepare();
await prepareMessages([message]);
await store.handleEvent(mkAddEvent(MessageFlag.read, [message.id]));
checkNotifiedOnce();
check(store).messages.values
.single.flags.deepEquals([MessageFlag.starred, MessageFlag.read]);
});
});
group('remove flag', () {
test('message is unknown', () async {
await prepare();
final message = eg.streamMessage(flags: [MessageFlag.read]);
await prepareMessages([message]);
await store.handleEvent(mkAddEvent(MessageFlag.read, [2]));
checkNotNotified();
check(store).messages.values
.single.flags.deepEquals([MessageFlag.read]);
});
test('affected message, unaffected message, absent message', () async {
await prepare();
final message1 = eg.streamMessage(flags: [MessageFlag.read]);
final message2 = eg.streamMessage(flags: [MessageFlag.read]);
final message3 = eg.streamMessage(flags: [MessageFlag.read]);
await prepareMessages([message1, message2]);
await store.handleEvent(mkRemoveEvent(MessageFlag.read, [message2, message3]));
checkNotifiedOnce();
check(store).messages
..[message1.id].flags.deepEquals([MessageFlag.read])
..[message2.id].flags.deepEquals([]);
});
test('other flags not affected', () async {
final message = eg.streamMessage(flags: [MessageFlag.starred, MessageFlag.read]);
await prepare();
await prepareMessages([message]);
await store.handleEvent(mkRemoveEvent(MessageFlag.read, [message]));
checkNotifiedOnce();
check(store).messages.values
.single.flags.deepEquals([MessageFlag.starred]);
});
});
});
group('handleReactionEvent', () {
test('add reaction', () async {
final originalMessage = eg.streamMessage(reactions: []);
await prepare();
await prepareMessages([originalMessage]);
final message = store.messages.values.single;
await store.handleEvent(
eg.reactionEvent(eg.unicodeEmojiReaction, ReactionOp.add, originalMessage.id));
checkNotifiedOnce();
check(store.messages).values.single
..identicalTo(message)
..reactions.isNotNull().jsonEquals([eg.unicodeEmojiReaction]);
});
test('add reaction; message is unknown', () async {
final someMessage = eg.streamMessage(reactions: []);
await prepare();
await prepareMessages([someMessage]);
await store.handleEvent(
eg.reactionEvent(eg.unicodeEmojiReaction, ReactionOp.add, 1000));
checkNotNotified();
check(store.messages).values.single
.reactions.isNull();
});
test('remove reaction', () async {
final eventReaction = Reaction(reactionType: ReactionType.unicodeEmoji,
emojiName: 'wave', emojiCode: '1f44b', userId: 1);
// Same emoji, different user. Not to be removed.
final reaction2 = Reaction(reactionType: ReactionType.unicodeEmoji,
emojiName: 'wave', emojiCode: '1f44b', userId: 2);
// Same user, different emoji. Not to be removed.
final reaction3 = Reaction(reactionType: ReactionType.unicodeEmoji,
emojiName: 'working_on_it', emojiCode: '1f6e0', userId: 1);
// Same user, same emojiCode, different emojiName. To be removed: servers
// key on user, message, reaction type, and emoji code, but not emoji name.
// So we mimic that behavior; see discussion:
// https://github.com/zulip/zulip-flutter/pull/256#discussion_r1284865099
final reaction4 = Reaction(reactionType: ReactionType.unicodeEmoji,
emojiName: 'hello', emojiCode: '1f44b', userId: 1);
final originalMessage = eg.streamMessage(
reactions: [reaction2, reaction3, reaction4]);
await prepare();
await prepareMessages([originalMessage]);
final message = store.messages.values.single;
await store.handleEvent(
eg.reactionEvent(eventReaction, ReactionOp.remove, originalMessage.id));
checkNotifiedOnce();
check(store.messages).values.single
..identicalTo(message)
..reactions.isNotNull().jsonEquals([reaction2, reaction3]);
});
test('remove reaction; message is unknown', () async {
final someMessage = eg.streamMessage(reactions: [eg.unicodeEmojiReaction]);
await prepare();
await prepareMessages([someMessage]);
await store.handleEvent(
eg.reactionEvent(eg.unicodeEmojiReaction, ReactionOp.remove, 1000));
checkNotNotified();
check(store.messages).values.single
.reactions.isNotNull().jsonEquals([eg.unicodeEmojiReaction]);
});
});
group('handle Poll related events', () {
Condition<Object?> conditionPollOption(String text, {Iterable<int>? voters}) =>
(it) => it.isA<PollOption>()..text.equals(text)..voters.deepEquals(voters ?? []);
Subject<Poll> checkPoll(Message message) =>
check(store.messages[message.id]).isNotNull().poll.isNotNull();
late int pollNotifiedCount;
void checkPollNotified({required int count}) {
check(pollNotifiedCount).equals(count);
pollNotifiedCount = 0;
// This captures any unchecked [messageList] notifications, to verify
// that poll live-updates do not trigger broader rebuilds.
checkNotNotified();
}
void checkPollNotNotified() => checkPollNotified(count: 0);
void checkPollNotifiedOnce() => checkPollNotified(count: 1);
group('handleSubmessageEvent', () {
Future<Message> preparePollMessage({
String? question,
List<(String, Iterable<int>)>? optionVoterIdsPairs,
User? messageSender,
}) async {
final effectiveMessageSender = messageSender ?? eg.selfUser;
final message = eg.streamMessage(sender: effectiveMessageSender);
final submessages = [
eg.submessage(senderId: effectiveMessageSender.userId,
content: eg.pollWidgetData(
question: question ?? 'example question',
options: (optionVoterIdsPairs != null)
? optionVoterIdsPairs.map((e) => e.$1).toList()
: ['foo', 'bar'])),
if (optionVoterIdsPairs != null)
for (int i = 0; i < optionVoterIdsPairs.length; i++)
...[
for (final voter in optionVoterIdsPairs[i].$2)
eg.submessage(senderId: voter,
content: PollVoteEventSubmessage(
key: PollEventSubmessage.optionKey(senderId: null, idx: i),
op: PollVoteOp.add)),
],
];
await prepare();
// Perform a single-message initial message fetch for [messageList] with
// submessages.
connection.prepare(json:
eg.newestGetMessagesResult(foundOldest: true, messages: []).toJson()
..['messages'] = [{
...message.toJson(),
"submessages": submessages.map(deepToJson).toList(),
}]);
await messageList.fetchInitial();
checkNotifiedOnce();
pollNotifiedCount = 0;
store.messages[message.id]!.poll!.addListener(() {
pollNotifiedCount++;
});
return message;
}
test('message is unknown', () async {
await prepare();
await store.handleEvent(eg.submessageEvent(1000, eg.selfUser.userId,
content: PollQuestionEventSubmessage(question: 'New question')));
checkNotNotified();
});
test('message has no submessages', () async {
final message = eg.streamMessage();
await prepare();
await prepareMessages([message]);
await store.handleEvent(eg.submessageEvent(message.id, eg.otherUser.userId,
content: PollQuestionEventSubmessage(question: 'New question')));
checkNotNotified();
check(store.messages[message.id]).isNotNull().poll.isNull();
});
test('ignore submessage event with malformed content', () async {
final message = await preparePollMessage(question: 'Old question');
await store.handleEvent(SubmessageEvent(
id: 0, msgType: SubmessageType.widget, submessageId: 123,
messageId: message.id,
senderId: eg.selfUser.userId,
content: jsonEncode({
'type': 'question',
// Invalid type for question
'question': 100,
})));
checkPollNotNotified();
checkPoll(message).question.equals('Old question');
});
group('question event', () {
test('update question', () async {
final message = await preparePollMessage(question: 'Old question');
await store.handleEvent(eg.submessageEvent(message.id, eg.selfUser.userId,
content: PollQuestionEventSubmessage(question: 'New question')));
checkPollNotifiedOnce();
checkPoll(message).question.equals('New question');
});
test('unauthorized question edits', () async {
final message = await preparePollMessage(
question: 'Old question',
messageSender: eg.otherUser,
);
checkPoll(message).question.equals('Old question');
await store.handleEvent(eg.submessageEvent(message.id, eg.selfUser.userId,
content: PollQuestionEventSubmessage(question: 'edit')));
checkPoll(message).question.equals('Old question');
});
});
group('new option event', () {
late Message message;
Future<void> handleNewOptionEvent(User sender, {
required String option,
required int idx,
}) async {
await store.handleEvent(eg.submessageEvent(message.id, sender.userId,
content: PollNewOptionEventSubmessage(option: option, idx: idx)));
checkPollNotifiedOnce();
}
test('add option', () async {
message = await preparePollMessage(
optionVoterIdsPairs: [('bar', [])]);
await handleNewOptionEvent(eg.otherUser, option: 'baz', idx: 0);
checkPoll(message).options.deepEquals([
conditionPollOption('bar'),
conditionPollOption('baz'),
]);
});
test('option with duplicate text ignored', () async {
message = await preparePollMessage(
optionVoterIdsPairs: [('existing', [])]);
checkPoll(message).options.deepEquals([conditionPollOption('existing')]);
await handleNewOptionEvent(eg.otherUser, option: 'existing', idx: 0);
checkPoll(message).options.deepEquals([conditionPollOption('existing')]);
});
test('option index limit exceeded', () async{
message = await preparePollMessage(
question: 'favorite number',
optionVoterIdsPairs: List.generate(1001, (i) => ('$i', [])),
);
checkPoll(message).options.length.equals(1001);
await handleNewOptionEvent(eg.otherUser, option: 'baz', idx: 1001);
checkPoll(message).options.length.equals(1001);
});
});
group('vote event', () {
late Message message;
Future<void> handleVoteEvent(String key, PollVoteOp op, User voter) async {
await store.handleEvent(eg.submessageEvent(message.id, voter.userId,
content: PollVoteEventSubmessage(key: key, op: op)));
checkPollNotifiedOnce();
}
test('add votes', () async {
message = await preparePollMessage();
String optionKey(int index) =>
PollEventSubmessage.optionKey(senderId: null, idx: index);
await handleVoteEvent(optionKey(0), PollVoteOp.add, eg.otherUser);
checkPoll(message).options.deepEquals([
conditionPollOption('foo', voters: [eg.otherUser.userId]),
conditionPollOption('bar', voters: []),
]);
await handleVoteEvent(optionKey(1), PollVoteOp.add, eg.otherUser);
checkPoll(message).options.deepEquals([
conditionPollOption('foo', voters: [eg.otherUser.userId]),
conditionPollOption('bar', voters: [eg.otherUser.userId]),
]);
await handleVoteEvent(optionKey(0), PollVoteOp.add, eg.selfUser);
checkPoll(message).options.deepEquals([
conditionPollOption('foo', voters: [eg.otherUser.userId, eg.selfUser.userId]),
conditionPollOption('bar', voters: [eg.otherUser.userId]),
]);
});
test('remove votes', () async {
message = await preparePollMessage(optionVoterIdsPairs: [
('foo', [eg.otherUser.userId, eg.selfUser.userId]),
('bar', [eg.selfUser.userId]),
]);
String optionKey(int index) =>
PollEventSubmessage.optionKey(senderId: null, idx: index);
await handleVoteEvent(optionKey(0), PollVoteOp.remove, eg.otherUser);
checkPoll(message).options.deepEquals([
conditionPollOption('foo', voters: [eg.selfUser.userId]),
conditionPollOption('bar', voters: [eg.selfUser.userId]),
]);
await handleVoteEvent(optionKey(1), PollVoteOp.remove, eg.selfUser);
checkPoll(message).options.deepEquals([
conditionPollOption('foo', voters: [eg.selfUser.userId]),
conditionPollOption('bar', voters: []),
]);
});
test('vote for unknown options', () async {
message = await preparePollMessage(optionVoterIdsPairs: [
('foo', [eg.selfUser.userId]),
('bar', []),
]);
final unknownOptionKey = PollEventSubmessage.optionKey(
senderId: eg.selfUser.userId,
idx: 10,
);
await handleVoteEvent(unknownOptionKey, PollVoteOp.remove, eg.selfUser);
checkPoll(message).options.deepEquals([
conditionPollOption('foo', voters: [eg.selfUser.userId]),
conditionPollOption('bar', voters: []),
]);
await handleVoteEvent(unknownOptionKey, PollVoteOp.add, eg.selfUser);
checkPoll(message).options.deepEquals([
conditionPollOption('foo', voters: [eg.selfUser.userId]),
conditionPollOption('bar', voters: []),
]);
});
test('ignore invalid vote op', () async {
message = await preparePollMessage(
optionVoterIdsPairs: [('foo', [])]);
checkPoll(message).options.deepEquals([conditionPollOption('foo')]);
await store.handleEvent(eg.submessageEvent(message.id, eg.otherUser.userId,
content: PollVoteEventSubmessage(
key: PollEventSubmessage.optionKey(senderId: null, idx: 0),
op: PollVoteOp.unknown)));
checkPollNotNotified();
checkPoll(message).options.deepEquals([conditionPollOption('foo')]);
});
});
});
group('handleMessageEvent with initial submessages', () {
late Message message;
final defaultPollWidgetData = eg.pollWidgetData(
question: 'example question',
options: ['foo', 'bar'],
);
final defaultOptionConditions = [
conditionPollOption('foo'),
conditionPollOption('bar'),
];
Future<void> handlePollMessageEvent({
SubmessageData? widgetData,
List<(User sender, PollEventSubmessage event)> events = const [],
}) async {
message = eg.streamMessage(sender: eg.otherUser, submessages: [
eg.submessage(
content: widgetData ?? defaultPollWidgetData,
senderId: eg.otherUser.userId),
for (final (sender, event) in events)
eg.submessage(content: event, senderId: sender.userId),
]);
await prepare();
await store.addMessage(message);
}
test('smoke', () async {
await handlePollMessageEvent();
checkPoll(message)
..question.equals(defaultPollWidgetData.extraData.question)
..options.deepEquals(defaultOptionConditions);
});
test('contains new question event', () async {
await handlePollMessageEvent(events: [
(eg.otherUser, PollQuestionEventSubmessage(question: 'new question')),
]);
checkPoll(message)
..question.equals('new question')
..options.deepEquals(defaultOptionConditions);
});
test('contains new option event', () async {
await handlePollMessageEvent(events: [
(eg.otherUser, PollNewOptionEventSubmessage(idx: 3, option: 'baz')),
(eg.selfUser, PollNewOptionEventSubmessage(idx: 0, option: 'quz')),
]);
checkPoll(message)
..question.equals(defaultPollWidgetData.extraData.question)
..options.deepEquals([
...defaultOptionConditions,
conditionPollOption('baz'),
conditionPollOption('quz'),
]);
});
test('contains vote events on initial canned options', () async {
await handlePollMessageEvent(events: [
(eg.otherUser, PollVoteEventSubmessage(key: 'canned,1', op: PollVoteOp.add)),
(eg.otherUser, PollVoteEventSubmessage(key: 'canned,2', op: PollVoteOp.add)),
(eg.otherUser, PollVoteEventSubmessage(key: 'canned,2', op: PollVoteOp.remove)),
(eg.selfUser, PollVoteEventSubmessage(key: 'canned,1', op: PollVoteOp.add)),
]);
checkPoll(message)
..question.equals(defaultPollWidgetData.extraData.question)
..options.deepEquals([
conditionPollOption('foo'),
conditionPollOption('bar', voters: [eg.otherUser.userId, eg.selfUser.userId]),
]);
});
test('contains vote events on post-creation options', () async {
await handlePollMessageEvent(events: [
(eg.otherUser, PollNewOptionEventSubmessage(idx: 0, option: 'baz')),
(eg.otherUser, PollVoteEventSubmessage(key: '${eg.otherUser.userId},0', op: PollVoteOp.add)),
(eg.selfUser, PollVoteEventSubmessage(key: '${eg.otherUser.userId},0', op: PollVoteOp.add)),
]);
checkPoll(message)
..question.equals(defaultPollWidgetData.extraData.question)
..options.deepEquals([
...defaultOptionConditions,
conditionPollOption('baz', voters: [eg.otherUser.userId, eg.selfUser.userId]),
]);
});
test('content with invalid widget_type', () async {
message = eg.streamMessage(sender: eg.otherUser, submessages: [
Submessage(
msgType: SubmessageType.widget,
content: jsonEncode({'widget_type': 'other'}),
senderId: eg.otherUser.userId,
),
]);
await prepare();
await store.addMessage(message);
check(store.messages[message.id]).isNotNull().poll.isNull();
});
});
});
}