Problem in Showdown

[kimjoar]

If you look at slide 15 in my presentation, there is a problem with Showdown not parsing # overskrift properly when inside a div. This is the code:

<div class="col">
  # overskrift
</div>

which gets parsed into:

<div class="col">
  <p># overskrift</p>
</div>

instead of the expected:

<div class="col">
  <h1>overskrift</h1>
</div>

Showdown however handles lists, urls and other markup inside divs as you can see on the same slide in my presentation.

[kimjoar]

Actually, parsing Markdown inside a div appear to not be a part of Gruber's implementation, but it is implemented in several Markdown parsers by setting markdown="1" on the div. However, on coreyti/showdown it is specifically noted that this is not supported in Showdown, but that the implementation should be "smart enough" too handle this syntax.

Which version/fork of Showdown is used in remark? I see that attacklab.net/showdown is down and that coreyti/showdown has not added any commits since April, even though there are 3 pull requests present. I thought about checking the code, but I don't want to start before I know which fork is used.

[gnab]

I believe this is the one: https://github.com/coreyti/showdown/blob/master/compressed/showdown.js

[kimjoar]

Okey, I might have to fork that project and see if I find a solution to the problem. The coreyti fork appears to not be maintained anymore, so we might need to use my fork in remark if I fix the problem.

[gnab]

Nice. Also, it seems indented headings doesn't work either, e.g. <space> # heading.

[kimjoar]

Ah, det er det som er bug-en jeg også kom over. Når jeg fjernet space-ene, fungerte overskriften i div-en. Skal få fikset det i Showdown.

[gnab]

Oh noes! All our English-speaking followers can no longer follow the issue with the mixed English / Norwegian commenting! :P

Ja, det er noen få slike særheter som med fordel kunne vært utbedret i Showdown.

[kimjoar]

Damn, I forgot. ;)

Oh, and there are, of course, no freakin' tests in Showdown ... That annoying.

[gnab]

It's indeed a bit legacy. There exists alternatives, though, with proper testing, like https://github.com/evilstreak/markdown-js. However, fixing the header-indentation issue may be just a tiny tweak done in a jiff.

[kimjoar]

I think evilstreak/markdown-js#34 is still a blocker for changing to that library. I'll look at the header indentation issue in Showdown. Hopefully it shouldn't be a problem.

[gnab]

Fixed by c4ec182.