Doc: Update setup instructions (#1207)

* Doc: Update setup instructions

Signed-off-by: nik-redhat <[email protected]>

* Add some packages

Signed-off-by: nik-redhat <[email protected]>

* Fix hostname

Signed-off-by: nik-redhat <[email protected]>

* Remove iptables flush

Signed-off-by: nik-redhat <[email protected]>

* Fix hostname parsing

Signed-off-by: nik-redhat <[email protected]>

Author: nik-redhat

README.md

@@ -10,8 +10,8 @@
 /_/ |_/_____/_____/_/  |_/_/ |_/ /_/     
                                          
 
-usage: redant_main.py [-h] -c CONFIG_FILE -t TEST_DIR [-l LOG_DIR]
-                      [-ll LOG_LEVEL] [-cc CONCUR_COUNT] [-xls EXCEL_SHEET][--show-backtrace]
+usage: redant_main.py [-h] -c CONFIG_FILE -t TEST_DIR [-l LOG_DIR] [-ll LOG_LEVEL]
+                      [-cc CONCUR_COUNT] [-xls EXCEL_SHEET][--show-backtrace] [-kold]
 
 Redant test framework main script.
 
@@ -30,6 +30,9 @@ optional arguments:
   -xls EXCEL_SHEET, --excel-sheet EXCEL_SHEET
                         Spreadsheet for result. Default value is NULL
   --show-backtrace      Show full backtrace on error
+  -kold, --keep-old-logs
+                        Don't clear the old glusterfs logs directory during environment setup.
+                        Default behavior is to clear the logs directory on each run.
 ```
 
 ## Tested and Supported Distros
@@ -39,6 +42,7 @@ optional arguments:
  |Fedora 32| :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: |
  |Fedora 34|:heavy_check_mark: | :heavy_multiplication_x: | ✖️ |
  |RHEL 7.9| :heavy_multiplication_x: | :heavy_check_mark: | :heavy_check_mark:|
+ |RHEL 8.4| :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: |
 
 The architects of any project won't be there forever with it 
 ( not everyone has the luxury to be a BDFL ), hence it is important to have 
@@ -63,11 +67,26 @@ The Documentation index can be found at [Docs](./docs/README.md)
 
 ## Set up
 
+### Pre requisites:
+1. Passwordless ssh between all (to self as well) the nodes in the cluster.
+2. Gluster installed on all the nodes and the bricks which would be used in the volumes,
+are created on all the servers.
+3. The following packages should be installed on all the nodes in the cluster, it includes
+some packages which are required by external tools used in some test cases:
+  1. git
+  2. make
+  3. gcc
+  4. autoconf
+  5. automake
+  6. cronie
+  7. rsync
+  8. numpy
+  9. sh
+
 ### To start Working:
 
 1. Clone redant repo.
-
-2. Populate the conf.yaml with relevant server and client details..
+2. Populate the [config.yml](./config/config.yml) with relevant server and client details.
 
 
 ### STEP-BY-STEP procedure to run:

common/ops/support_ops/machine_ops.py

@@ -200,11 +200,6 @@ def hard_terminate(self, server_list: list, client_list: list,
 
         self.remove_snap_lv(lv_dict)
 
-        # Flush the IP tables
-        cmd = "iptables --flush"
-        for node in server_list:
-            self.execute_abstract_op_node(cmd, node, False)
-
         self.es.reset_ds()
 
     def check_os(self, os_name: str, nodes: str,

config/config.yml

@@ -12,7 +12,7 @@ servers_info:
         brick_root: ["/bricks"]
     "4.4.4.4":
         brick_root: ["/bricks"]
-        
+
 #clients_info - All the relevant information about the clients
 clients_info:
     "5.5.5.5":

core/redant_main.py

@@ -54,7 +54,8 @@ def pars_args():
                         dest="show_backtrace", action='store_true')
     parser.add_argument("-kold", "--keep-old-logs",
                         help="Don't clear the old glusterfs logs directory "
-                        "during environment setup",
+                        "during environment setup. Default behavior is to "
+                        "clear the logs directory on each run.",
                         dest="keep_logs", action='store_true')
     return parser.parse_args()
 

tests/functional/afr/heal/test_server_side_healing_happens_only_when_glustershd_running.py

@@ -172,5 +172,5 @@ def run_test(self, redant):
 
         # Wait for heal to complete
         if not redant.monitor_heal_completion(self.server_list[0],
-                                              self.vol_name):
+                                              self.vol_name, 2400):
             raise Exception("Heal has not yet completed")

tests/functional/dht/test_file_creation.py

@@ -19,6 +19,7 @@
 """
 
 # disruptive;dist-disp,dist-arb,dist-rep,dist
+from socket import gethostbyname
 from tests.d_parent_test import DParentTest
 
 
@@ -53,6 +54,7 @@ def _is_file_present_on_brick(self, file_name):
 
         for brick in brick_list['brickdir_paths']:
             host, path = brick.split(':')
+            host = gethostbyname(host)
             ret = self._file_exists(host, path)
             if not ret:
                 raise Exception(f"File {file_name} is not present on {brick}")
@@ -71,6 +73,7 @@ def _compare_file_permissions(self, file_name,
             file_info_brick = []
             for brick in brick_list['brickdir_paths']:
                 host, path = brick.split(':')
+                host = gethostbyname(host)
                 info_brick = self.redant.get_file_stat(host, path)
                 file_info_brick.append(info_brick['msg']['permission'])
 
@@ -93,6 +96,7 @@ def _check_change_time_brick(self, file_name):
         brick_mtime = []
         for brick in brick_list['brickdir_paths']:
             host, path = brick.split(':')
+            host = gethostbyname(host)
             cmd = f"ls -lR {path}"
             self.redant.execute_abstract_op_node(cmd, host)
             file_ctime_brick = self.redant.get_file_stat(host, path)
@@ -141,6 +145,7 @@ def _compare_file_md5sum_on_bricks(self, link_file_name):
         md5sum_list_test_file = []
         for brick in brick_list_test_file['brickdir_paths']:
             host, path = brick.split(':')
+            host = gethostbyname(host)
             md5sum_test_file = self.redant.get_md5sum(host, path).split()[0]
             md5sum_list_test_file.append(md5sum_test_file)
 
@@ -150,6 +155,7 @@ def _compare_file_md5sum_on_bricks(self, link_file_name):
         md5sum_list_link_file = []
         for brick in brick_list_link_file['brickdir_paths']:
             host, path = brick.split(':')
+            host = gethostbyname(host)
             md5sum_link_file = self.redant.get_md5sum(host, path).split()[0]
             md5sum_list_link_file.append(md5sum_link_file)
 
@@ -167,6 +173,7 @@ def _compare_gfid_xattr_on_files(self, link_file_name, expected=True):
         xattr_list_test_file = []
         for brick in brick_list_test_file['brickdir_paths']:
             host, path = brick.split(':')
+            host = gethostbyname(host)
             xattr_test_file = self.redant.get_fattr(path, "trusted.gfid", host)
             xattr_test_file = xattr_test_file[1].split('=')[1].strip()
             xattr_list_test_file.append(xattr_test_file[1:-1])
@@ -177,6 +184,7 @@ def _compare_gfid_xattr_on_files(self, link_file_name, expected=True):
         xattr_list_link_file = []
         for brick in brick_list_link_file['brickdir_paths']:
             host, path = brick.split(':')
+            host = gethostbyname(host)
             xattr_link_file = self.redant.get_fattr(path, "trusted.gfid", host)
             xattr_link_file = xattr_link_file[1].split('=')[1].strip()
             xattr_list_link_file.append(xattr_link_file[1:-1])