hlapi add missing textual team member role handling

Author: cconard96

src/Glpi/Api/HL/Controller/ITILController.php

@@ -1380,6 +1380,7 @@ private static function getCleanTeam(CommonITILObject $item): array
                 }
             }
             // Add a link to the full resource represented by the team member (User, Group, etc)
+            $member['id'] = $member_items_id;
             $member['href'] = $member_itemtype::getFormURLWithID($member_items_id);
             // Replace role with non-localized textual representation
             try {
@@ -1472,11 +1473,7 @@ public function getTeamMembersByRole(Request $request): Response
         /** @var CommonITILObject $item */
         $item = $request->getParameter('_item');
 
-        // TODO Handle textual representations of roles
-        $role_id = $request->getAttribute('role');
-        if ($role_id === null) {
-            self::getInvalidParametersErrorResponse();
-        }
+        $role_id = self::getRoleName($request->getAttribute('role'));
 
         $team = self::getCleanTeam($item);
         $team = array_filter($team, static fn($v) => $v['role'] === $role_id, ARRAY_FILTER_USE_BOTH);
@@ -1521,8 +1518,7 @@ public function addTeamMember(Request $request): Response
 
         $member_itemtype = $request->getParameter('type');
         $member_items_id = $request->getParameter('id');
-        // TODO Handle textual representations of roles
-        $role_id = $request->getParameter('role');
+        $role_id = self::getRoleID($request->getParameter('role'));
 
         $result = $item->addTeamMember($member_itemtype, $member_items_id, [
             'role'  => $role_id,
@@ -1571,7 +1567,6 @@ public function removeTeamMember(Request $request): Response
 
         $member_itemtype = $request->getParameter('type');
         $member_items_id = $request->getParameter('id');
-        // TODO Handle textual representations of roles
         $role_id = self::getRoleID($request->getParameter('role'));
 
         $result = $item->deleteTeamMember($member_itemtype, $member_items_id, [

tests/functional/Glpi/Api/HL/Controller/ITILControllerTest.php

@@ -605,4 +605,97 @@ public function testRestrictedRead()
             }
         }
     }
+
+    public function testCRUDTeamMembers()
+    {
+        $this->loginWeb();
+        $this->api->getRouter()->registerAuthMiddleware(new InternalAuthMiddleware());
+        $ticket = $this->createItem(Ticket::class, [
+            'name' => __FUNCTION__,
+            'content' => 'test',
+            'entities_id' => getItemByTypeName('Entity', '_test_root_entity', true),
+        ]);
+
+        // Add team members
+        $members = [
+            ['type' => 'User', 'id' => 3, 'role' => 'requester'],
+            ['type' => 'User', 'id' => 2, 'role' => 'observer'],
+            ['type' => 'User', 'id' => 4, 'role' => 'assigned'],
+        ];
+        foreach ($members as $member) {
+            $request = new Request('POST', "/Assistance/Ticket/{$ticket->getID()}/TeamMember");
+            $request->setParameter('type', $member['type']);
+            $request->setParameter('id', $member['id']);
+            $request->setParameter('role', $member['role']);
+            $this->api->call($request, function ($call) {
+                /** @var \HLAPICallAsserter $call */
+                $call->response->isOK();
+            });
+        }
+
+        // Get all members
+        $this->api->call(new Request('GET', "/Assistance/Ticket/{$ticket->getID()}/TeamMember"), function ($call) use ($members) {
+            /** @var \HLAPICallAsserter $call */
+            $call->response
+                ->isOK()
+                ->jsonContent(function ($content) use ($members) {
+                    $this->assertCount(count($members), $content);
+                    $member_ids = array_column($members, 'id');
+                    foreach ($content as $member) {
+                        $this->assertContains($member['id'], $member_ids);
+                    }
+                });
+        });
+
+        // Get by role
+        $this->api->call(new Request('GET', "/Assistance/Ticket/{$ticket->getID()}/TeamMember/requester"), function ($call) {
+            /** @var \HLAPICallAsserter $call */
+            $call->response
+                ->isOK()
+                ->jsonContent(function ($content) {
+                    $this->assertCount(1, $content);
+                    $this->assertEquals(3, array_values($content)[0]['id']);
+                });
+        });
+        $this->api->call(new Request('GET', "/Assistance/Ticket/{$ticket->getID()}/TeamMember/observer"), function ($call) {
+            /** @var \HLAPICallAsserter $call */
+            $call->response
+                ->isOK()
+                ->jsonContent(function ($content) {
+                    $this->assertCount(1, $content);
+                    $this->assertEquals(2, array_values($content)[0]['id']);
+                });
+        });
+        $this->api->call(new Request('GET', "/Assistance/Ticket/{$ticket->getID()}/TeamMember/assigned"), function ($call) {
+            /** @var \HLAPICallAsserter $call */
+            $call->response
+                ->isOK()
+                ->jsonContent(function ($content) {
+                    $this->assertCount(1, $content);
+                    $this->assertEquals(4, array_values($content)[0]['id']);
+                });
+        });
+
+        // Remove members
+        foreach ($members as $member) {
+            $request = new Request('DELETE', "/Assistance/Ticket/{$ticket->getID()}/TeamMember");
+            $request->setParameter('type', $member['type']);
+            $request->setParameter('id', $member['id']);
+            $request->setParameter('role', $member['role']);
+            $this->api->call($request, function ($call) {
+                /** @var \HLAPICallAsserter $call */
+                $call->response->isOK();
+            });
+        }
+
+        // Verify removal
+        $this->api->call(new Request('GET', "/Assistance/Ticket/{$ticket->getID()}/TeamMember"), function ($call) {
+            /** @var \HLAPICallAsserter $call */
+            $call->response
+                ->isOK()
+                ->jsonContent(function ($content) {
+                    $this->assertCount(0, $content);
+                });
+        });
+    }
 }