test(itil): Add cypress test on the readonly field logic

Author: froozeify

src/CommonITILObject.php

@@ -2345,7 +2345,6 @@ public function enforceReadonlyFields(array $input, bool $isAdd = false): array
     {
         $tt = $this->getITILTemplateFromInput($input);
         if (!$tt) {
-            dump('Template not found');
             return $input;
         }
 
@@ -8300,7 +8299,7 @@ public function getITILTemplateFromInput(array $input = []): ?ITILTemplate
             $type = $this->fields['type'];
         }
 
-        $categid = $input['itilcategories_id'] ?? $this->fields['itilcategories_id'];
+        $categid = $input['itilcategories_id'] ?? $this->fields['itilcategories_id'] ?? null;
         if (is_null($categid)) {
             return null;
         }

tests/cypress/e2e/ITILObject/ticket_form.cy.js

@@ -334,4 +334,52 @@ describe("Ticket Form", () => {
             cy.findByRole('cell').should('contain.text', 'No results found');
         });
     });
+
+    it('Create/update a ticket using a template with readonly fields', () => {
+        const ticket_template_name = `test template ${rand}`;
+        cy.createWithAPI('TicketTemplate', {
+            'name': ticket_template_name,
+        }).as('ticket_template_id');
+
+        cy.get('@ticket_template_id').then((ticket_template_id) => {
+            cy.createWithAPI('TicketTemplatePredefinedField', {
+                'tickettemplates_id': ticket_template_id, // Default template
+                'num': 10, // Urgency
+                'value': 4, // High
+            });
+
+            cy.createWithAPI('TicketTemplateReadonlyField', {
+                'tickettemplates_id': ticket_template_id,
+                'num': 10,
+            });
+
+            cy.createWithAPI('ITILCategory', {
+                'name':ticket_template_name,
+                'tickettemplates_id': ticket_template_id,
+                'tickettemplates_id_incident': ticket_template_id,
+                'tickettemplates_id_demand': ticket_template_id,
+                'changetemplates_id': ticket_template_id,
+                'problemtemplates_id': ticket_template_id,
+            });
+        });
+
+        // Create form
+        cy.visit(`/front/ticket.form.php`);
+
+        // intercept form submit
+        cy.intercept('POST', '/front/ticket.form.php').as('submit');
+
+        cy.getDropdownByLabelText('Category').selectDropdownValue(`»${ticket_template_name}`);
+
+        // We change the value of a readonly field, it should be ignored
+        cy.get('input[name="urgency"]').invoke('val', '1');
+        cy.findByRole('button', {'name': 'Add'}).click();
+        cy.wait('@submit').its('response.statusCode').should('eq', 200);
+        cy.get('input[name="urgency"]').should('have.value', '4'); // Should be the template 4 value
+
+        // We try updating it
+        cy.get('input[name="urgency"]').invoke('val', '1');
+        cy.findByRole('button', {'name': 'Save'}).click();
+        cy.get('input[name="urgency"]').should('have.value', '4'); // Should be the template 4 value
+    });
 });

tests/src/AbstractITILTemplateReadonlyFieldTest.php

@@ -148,6 +148,24 @@ public function setUp(): void
         $this->login();
     }
 
+    public function testHandleReadonlyFieldsWithNoTemplate(): void
+    {
+        $itil_object = $this->getITILClass();
+        $input = [
+            'urgency'           => Urgency::LOW->value,
+            'name'              => 'Some content',
+            'status'            => CommonITILObject::INCOMING,
+            'entities_id'       => 0,
+        ];
+        if ($itil_object instanceof Ticket) {
+            $input['type'] = Ticket::INCIDENT_TYPE;
+        }
+
+        $processed_input = $itil_object->enforceReadonlyFields($input, true);
+
+        $this->assertEquals(Urgency::LOW->value, $processed_input['urgency']);
+        $this->assertEquals('Some content', $processed_input['name']);
+    }
 
     public function testHandleReadonlyFieldsOnAddWithPredefined(): void
     {