Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "licensed" and "authorized" #42

Closed
jmccrae opened this issue Jan 2, 2019 · 4 comments · Fixed by #863
Closed

Merge "licensed" and "authorized" #42

jmccrae opened this issue Jan 2, 2019 · 4 comments · Fixed by #863
Assignees
Labels
synset duplicate A synset has been claimed as a duplicate
Milestone

Comments

@jmccrae
Copy link
Member

jmccrae commented Jan 2, 2019

Highly similar definitions:

commissioned, licensed, licenced, accredited ewn-00180111-s

given official approval to act

authorized, authorised, authoritative ewn-01636851-s

sanctioned by established authority

@jmccrae jmccrae added the synset duplicate A synset has been claimed as a duplicate label Jan 2, 2019
@jmccrae jmccrae added this to the v3.3 milestone Jan 2, 2019
@jmccrae
Copy link
Member Author

jmccrae commented Jan 19, 2020

Issue #35 again

@jmccrae jmccrae modified the milestones: 2020 Release, 2021 Release Jan 19, 2020
@arademaker
Copy link
Member

We should merge them.

@dcillessen
Copy link

The difference between these synsets is where the definitions derive authority from, with ewn-00180111-s "licensed" deriving it from an "office" and ewn-01636851-s deriving it from an "authority" in their definitions.

This understanding, however, isn't backed up by the way these synsets are placed within the network. ewn-01636851-s "authorized" is related with ewn-01636580-a "official" (as "similar to") while ewn-00180111-s "licensed" is related with ewn-00179875-a "authorized" (as "similar to").

In my mind we should restructure the relations surrounding these synsets to support their definitions rather than merging them. (Perhaps by relating ewn-01636851-s with ewn-00179875-a and ewn-00180111-s with ewn-01636580-a.) I'm open to being wrong here though because doing what I'm proposing might have ramifications on higher levels of the hierarchy or lead to higher level inconsistency.

@Ciara97olo
Copy link
Collaborator

I agree that the relations should be changed to support the definitions and the synsets should not be merged.

@jmccrae jmccrae modified the milestones: 2021 Release, 2022 Release Jul 14, 2021
@jmccrae jmccrae self-assigned this Aug 9, 2022
@jmccrae jmccrae linked a pull request Aug 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synset duplicate A synset has been claimed as a duplicate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants