Skip to content

Follow XDG spec on windows #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dsisnero opened this issue Jan 6, 2023 · 3 comments · May be fixed by #2627
Open

Follow XDG spec on windows #1498

dsisnero opened this issue Jan 6, 2023 · 3 comments · May be fixed by #2627
Labels
dormant Marked by stale bot on close feature-request question Further information is requested

Comments

@dsisnero
Copy link

dsisnero commented Jan 6, 2023

Is your feature request related to a problem? Please describe.
I use windows and have set XDG_CONFIG dirs (XDG_CONFIG_HOME, XDG_CACHE_HOME) but gitui isn't honoring them

Describe the solution you'd like
If XDG_CONFIG_HOME is set on any os, use XDG_CONFIG_HOME/gitui as directory for config file. If it is not set, fall back to os default
@extrawurst
Copy link
Collaborator

sounds plausible. should be an easy change. are you willing to make a PR?

@extrawurst extrawurst added this to the v0.23 milestone Jan 8, 2023
@pm100 pm100 mentioned this issue Apr 12, 2023
Closed
2 tasks
@pm100
Copy link
Contributor

pm100 commented Apr 14, 2023

@dsisnero what XDG_XXX_HOME settings were not working for you. Most of the git plumbing is done by a common git library (libgit2) that does obey XDG on all platforms, including windows.

gitui has a couple of places itself where is does not check where it should or could but thats very limited (location of generated log file, location of keyboard mapping file)

I can fix those but want to be sure I have not missed something

@extrawurst extrawurst added the question Further information is requested label Apr 22, 2023
@extrawurst extrawurst removed this from the v0.23 milestone Apr 22, 2023
@stale Stale
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label Dec 15, 2023
@KlassyKat KlassyKat linked a pull request Apr 29, 2025 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dormant Marked by stale bot on close feature-request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/respect xdg spec on all os KlassyKat/gitui
make XDG_XXX_HOME work for Windows pm100/gitui
3 participants
@dsisnero @pm100 @extrawurst