[public-api] Correctly map 401 to Unathenticated (#16711)

Author: easyCZ

components/public-api-server/pkg/proxy/errors.go

@@ -33,7 +33,7 @@ func categorizeRPCError(err error) *connect.Error {
 			return connect.NewError(connect.CodeInvalidArgument, fmt.Errorf(rpcErr.Message))
 		// components/gitpod-protocol/src/messaging/error.ts
 		case 401:
-			return connect.NewError(connect.CodePermissionDenied, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeUnauthenticated, fmt.Errorf(rpcErr.Message))
 		// components/gitpod-protocol/src/messaging/error.ts
 		case 403:
 			return connect.NewError(connect.CodePermissionDenied, fmt.Errorf(rpcErr.Message))

components/public-api-server/pkg/proxy/errors_test.go

@@ -34,6 +34,13 @@ func TestConvertError(t *testing.T) {
 			},
 			ExpectedError: connect.NewError(connect.CodeInvalidArgument, fmt.Errorf("user id is a required argument")),
 		},
+		{
+			Input: &jsonrpc2.Error{
+				Code:    401,
+				Message: "user is not authenticated",
+			},
+			ExpectedError: connect.NewError(connect.CodeUnauthenticated, fmt.Errorf("user is not authenticated")),
+		},
 		{
 			Input: &jsonrpc2.Error{
 				Code:    -32603,