fix: use consistent pattern for test result detection

Co-authored-by: Mossaka <[email protected]>

Author: Copilot

.github/workflows/test-playwright.yml

@@ -68,9 +68,7 @@ jobs:
       - name: Run Playwright MCP tests
         id: run-tests
         run: |
-          set +e
           sudo -E npm run test:integration -- playwright-mcp.test.ts 2>&1 | tee test-output.log
-          echo "exit_code=$?" >> $GITHUB_OUTPUT
         continue-on-error: true
 
       - name: Clean npm cache
@@ -85,12 +83,8 @@ jobs:
           npx tsx scripts/ci/generate-test-summary.ts "playwright-mcp.test.ts" "Playwright MCP Tests" test-output.log
 
       - name: Check test results
-        if: always()
-        run: |
-          if [ "${{ steps.run-tests.outputs.exit_code }}" != "0" ]; then
-            echo "Tests failed with exit code ${{ steps.run-tests.outputs.exit_code }}"
-            exit 1
-          fi
+        if: steps.run-tests.outcome == 'failure'
+        run: exit 1
 
       - name: Post-test cleanup
         if: always()

tests/integration/playwright-mcp.test.ts

@@ -40,31 +40,35 @@ describe('Playwright MCP Integration', () => {
   });
 
   test('Test 1: Playwright MCP can navigate to GitHub and verify page title', async () => {
-    // Create MCP config for playwright
-    const mcpConfig = {
-      mcpServers: {
-        playwright: {
-          type: 'local',
-          command: 'docker',
-          args: [
-            'run',
-            '-i',
-            '--rm',
-            '--init',
-            'mcr.microsoft.com/playwright/mcp',
-            '--output-dir',
-            '/tmp/gh-aw/mcp-logs/playwright',
-            '--allowed-hosts',
-            'localhost;localhost:*;127.0.0.1;127.0.0.1:*;github.com'
-          ],
-          tools: ['*']
-        }
-      }
-    };
+    // Create MCP config for playwright using a heredoc to avoid injection risks
+    const mcpConfigJson = `{
+  "mcpServers": {
+    "playwright": {
+      "type": "local",
+      "command": "docker",
+      "args": [
+        "run",
+        "-i",
+        "--rm",
+        "--init",
+        "mcr.microsoft.com/playwright/mcp",
+        "--output-dir",
+        "/tmp/gh-aw/mcp-logs/playwright",
+        "--allowed-hosts",
+        "localhost;localhost:*;127.0.0.1;127.0.0.1:*;github.com"
+      ],
+      "tools": ["*"]
+    }
+  }
+}`;
 
     // Write MCP config to a temporary file and set up the test
+    // Using heredoc to safely write the config without shell escaping issues
     const result = await runner.runWithSudo(
-      `bash -c "mkdir -p ~/.copilot && echo '${JSON.stringify(mcpConfig)}' > ~/.copilot/mcp-config.json && cat ~/.copilot/mcp-config.json"`,
+      `bash -c 'mkdir -p ~/.copilot && cat > ~/.copilot/mcp-config.json << "MCPEOF"
+${mcpConfigJson}
+MCPEOF
+cat ~/.copilot/mcp-config.json'`,
       {
         allowDomains: [
           'github.com',