Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to use v0.2.0 on jekyll v4.2.2 #22

Open
daipom opened this issue Jul 5, 2022 · 8 comments
Open

I want to use v0.2.0 on jekyll v4.2.2 #22

daipom opened this issue Jul 5, 2022 · 8 comments

Comments

@daipom
Copy link

daipom commented Jul 5, 2022

I use v0.1.6 on jekyll v4.2.2.

However, 9bc5971 limited jekyll's version to 3.9.x.

So I can't update this version now.

Is there any reason for this version limitation?

@daipom
Copy link
Author

daipom commented Jul 5, 2022

Maybe because github-pages is limiting the version to 3.9.x?

The versions for github-pages are managed as above,
so there is no need to fix the version to 3.9.x with this gem
if this works with 4.2.2.

I can use this v0.1.6 with jekyll v4.2.2,
so If new features are not a problem in v4.2.2, then this limitation should not be necessary.

I will check if this v0.2.0 works with jekyll v4.2.2.

If it works fine, I'd be happy to have this version limitation removed.

@daipom
Copy link
Author

daipom commented Jul 6, 2022

I have checked this v0.2.0 works with jekyll v4.2.2!
I'd be happy to have this version limitation removed!

@jdvp
Copy link

jdvp commented Oct 22, 2022

@yoannchaudet Also wondering about if the strict versioning for Jekyll is required. I had wanted to update a dependent plugin to use the latest version but it's not possible due to version conflict now so was just wondering

@yoannchaudet
Copy link
Contributor

@jdvp github/jekyll-commonmark-ghpages is meant to be used along github/pages-gem which we use to build Pages sites "the old way" at GitHub. We cannot upgrade Jekyll to the latest version because of its many breaking changes that would mean breaking millions of sites.

Since we introduced Pages support for custom Actions workflows as an official way to deploy sites, I strongly suggest leveraging a custom workflow to use the latest version of Jekyll along with its official commonmark plugin: https://github.com/jekyll/jekyll-commonmark.

We already have an example of workflow for latest Jekyll here: https://github.com/actions/starter-workflows/blob/main/pages/jekyll.yml. It is bare bone and does not do any magic but you are free to bring in all the plugins you wish because we don't need to control an allow list anymore to make sure your builds are secure when Actions is doing it.

@jdvp
Copy link

jdvp commented Oct 25, 2022

@yoannchaudet Sorry, I should have been more clear. I own the other gem that depends on this one and adds code-tab functionality to jekyll sites. I already leverage workflows for my own personal site but was curious why this specific gem needs to be specifically tied to jekyll v3.9? I have tried it locally with even the latest jekyll and it appears to work (edit : for previous version of this gem I mean, did update break compatibility with Jekyll 4+?)

I understand if this will be tagged wontfix though

@yoannchaudet
Copy link
Contributor

oh my mistake! I did not realize you add a dependency to here 🙃

https://github.com/github/pages-gem is where we cannot go past Jekyll 3.9.

@jdvp
Copy link

jdvp commented Oct 26, 2022

@yoannchaudet Oh makes sense to me! I'll see if I can migrate to using jekyll-commonmark directly, although i think when I tried in the past it wasn't a 1 to 1 switch. Thanks for the info!

@fsmeier
Copy link

fsmeier commented Aug 31, 2023

It seems that you can not use this gem anymore because of that limitation:

  • use latest ruby version (3.2)
  • update jekyll-commonmark-ghpages to use newer version of commonmarker (old one seems to be incompatible with ruby 3.2.0)

-> can not update because of usage of jekyll 4.2 (which wasnt a constraint before)

@yoannchaudet you are on parental leave, right? anyone else with permissions to move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants