Fixing bug in JCA cipher modeling. intermediate operations should not be key operations.

bdrodes · bdrodes · commit dbd66e64c6d1 · 2025-05-16T11:23:42.000-04:00
diff --git a/java/ql/lib/experimental/quantum/JCA.qll b/java/ql/lib/experimental/quantum/JCA.qll
@@ -611,6 +611,8 @@ module JCAModel {
   }
 
   class CipherOperationInstance extends Crypto::KeyOperationInstance instanceof CipherOperationCall {
+    CipherOperationInstance() { not this.isIntermediate() }
+
     override Crypto::KeyOperationSubtype getKeyOperationSubtype() {
       if CipherFlowAnalysisImpl::hasInit(this)
       then result = CipherFlowAnalysisImpl::getInitFromUse(this, _, _).getCipherOperationModeType()

Original file line number	Diff line number	Diff line change
`@@ -611,6 +611,8 @@ module JCAModel {`
`611`	`611`	`}`
`612`	`612`
`613`	`613`	`class CipherOperationInstance extends Crypto::KeyOperationInstance instanceof CipherOperationCall {`
	`614`	`+ CipherOperationInstance() { not this.isIntermediate() }`
	`615`	`+`
`614`	`616`	`override Crypto::KeyOperationSubtype getKeyOperationSubtype() {`
`615`	`617`	`if CipherFlowAnalysisImpl::hasInit(this)`
`616`	`618`	`then result = CipherFlowAnalysisImpl::getInitFromUse(this, _, _).getCipherOperationModeType()`