C++: It turns out __assert_fail is special (see DefaultOptions.qll) so we don't need a body here. And the body was wrong.

geoffw0 · geoffw0 · commit d2dd19a293c6 · 2021-01-19T16:56:19.000Z
diff --git a/cpp/ql/test/experimental/query-tests/Security/CWE/CWE-401/semmle/tests/test.c b/cpp/ql/test/experimental/query-tests/Security/CWE/CWE-401/semmle/tests/test.c
@@ -2,7 +2,7 @@
 #define NULL ((void*)0)
 
 #define assert(x) if (!(x)) __assert_fail(#x,__FILE__,__LINE__)
-void __assert_fail(const char *assertion, const char *file, int line) {  }
+void __assert_fail(const char *assertion, const char *file, int line);
 
 void aFakeFailed_1(int file, int line)
 {

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`#define NULL ((void*)0)`
`3`	`3`
`4`	`4`	`#define assert(x) if (!(x)) __assert_fail(#x,__FILE__,__LINE__)`
`5`		`-void __assert_fail(const char assertion, const char file, int line) { }`
	`5`	`+void __assert_fail(const char assertion, const char file, int line);`
`6`	`6`
`7`	`7`	`void aFakeFailed_1(int file, int line)`
`8`	`8`	`{`