Remove needless casts

smowton · web-flow · commit c74eac493019 · 2021-11-24T12:18:05.000Z
diff --git a/java/ql/src/experimental/Security/CWE/CWE-400/ThreadResourceAbuse.qll b/java/ql/src/experimental/Security/CWE/CWE-400/ThreadResourceAbuse.qll
@@ -35,10 +35,10 @@ class PauseThreadSink extends DataFlow::Node {
 /** A sanitizer for lessThan check. */
 class LessThanSanitizer extends DataFlow::BarrierGuard instanceof ComparisonExpr {
   override predicate checks(Expr e, boolean branch) {
-    e = this.(ComparisonExpr).getLesserOperand() and
+    e = super.getLesserOperand() and
     branch = true
     or
-    e = this.(ComparisonExpr).getGreaterOperand() and
+    e = super.getGreaterOperand() and
     branch = false
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -35,10 +35,10 @@ class PauseThreadSink extends DataFlow::Node {`
`35`	`35`	`/** A sanitizer for lessThan check. */`
`36`	`36`	`class LessThanSanitizer extends DataFlow::BarrierGuard instanceof ComparisonExpr {`
`37`	`37`	`override predicate checks(Expr e, boolean branch) {`
`38`		`- e = this.(ComparisonExpr).getLesserOperand() and`
	`38`	`+ e = super.getLesserOperand() and`
`39`	`39`	`branch = true`
`40`	`40`	`or`
`41`		`- e = this.(ComparisonExpr).getGreaterOperand() and`
	`41`	`+ e = super.getGreaterOperand() and`
`42`	`42`	`branch = false`
`43`	`43`	`}`
`44`	`44`	`}`